Repository navigation
TYP: fix stubtest errors in numpy.lib._arraysetops_impl - #28528
Merged
charris merged 1 commit intoMar 15, 2025
Merged
charris merged 1 commit into
charris merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Ported from numpy/numtype#234 --- This fixes the signatures of the following public `numpy` members: - `unique` - `unique_all` - `unique_counts` - `unique_inverse` - `unique_values` - `intersect1d` - `ediff1d`
Copy link
Copy Markdown
|
Diff from mypy_primer, showing the effect of this PR on type check results on a corpus of open source code: xarray (https://github.com/pydata/xarray)
+ xarray/core/indexing.py: note: In function "_decompose_vectorized_indexer":
+ xarray/core/indexing.py:1144: error: Argument 1 to "append" of "list" has incompatible type "ndarray[tuple[int, ...], dtype[Any]]"; expected "slice[Any, Any, Any]" [arg-type]
+ xarray/core/indexing.py:1145: error: Argument 1 to "append" of "list" has incompatible type "ndarray[Any, Any]"; expected "slice[Any, Any, Any]" [arg-type]
+ xarray/core/indexing.py: note: At top level:
scipy (https://github.com/scipy/scipy)
+ scipy/spatial/tests/test_spherical_voronoi.py:255: error: Incompatible types in assignment (expression has type "ndarray[tuple[int, ...], dtype[Any]]", variable has type "list[ndarray[tuple[int, ...], dtype[Any]]]") [assignment]
|
Sorry, something went wrong.
jorenham
marked this pull request as draft
March 14, 2025 23:44
jorenham
marked this pull request as ready for review
March 14, 2025 23:51
Copy link
Copy Markdown
Member
Author
|
The new mypy_primer errors (xarray, scipy) are mypy-only errors that are related to reassignment, similar to the mypy-only errors we have seen before with the 2.2 release. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks Joren. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This one might be a bit too risky to backport. Mypy is working on fixing the underlying issue, though: python/mypy#18727 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from numpy/numtype#234
This fixes the signatures of the following public numpy members: