| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Temporarily enabled --allow-redefine-new by default. I also had to enable --local-partial-types. Note that both of these are expected to generate new errors. |
Sorry, something went wrong.
|
There are still some false positives in the mypy_primer output that I want to fix before merging, but I won't attempt to fix every single issue in this PR, since the new behavior is behind a flag. |
Sorry, something went wrong.
Sure, there is no point in turning this into a mega-PR. Let me know if/when you want me to review this PR again. |
Sorry, something went wrong.
|
Btw if you want a clean mypy_primer diff on the local partial types front, you can try something like: diff --git a/.github/workflows/mypy_primer.yml b/.github/workflows/mypy_primer.yml
index ee8684847..a8220e1b6 100644
--- a/.github/workflows/mypy_primer.yml
+++ b/.github/workflows/mypy_primer.yml
@@ -66,6 +66,7 @@ jobs:
--num-shards 5 --shard-index ${{ matrix.shard-index }} \
--debug \
--additional-flags="--debug-serialize" \
+ --additional-flags="--local-partial-types" \
--output concise \
| tee diff_${{ matrix.shard-index }}.txt
) || [ $? -eq 1 ]
|
Sorry, something went wrong.
Since the PR also changes how None types are inferred, this actually generates a larger diff. I'm not sure if there is a good way to isolate the changes caused by the flag in mypy primer. |
Sorry, something went wrong.
This reverts commit 24afddd.
|
@ilevkivskyi I'm not planning any further changes before merging. I'd like to merge this in a few days. It would be great if you can review my recent changes. |
Sorry, something went wrong.
…l-types" This reverts commit 69fd839.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
There was a problem hiding this comment.
LG, thanks!
Sorry, something went wrong.
The feature was introduced in #18727.
The feature was introduced in #18727.
| Back | FazBrowse Home | New Git URL |
Infer union types for simple variables from multiple assignments, if the variable isn't annotated. The feature is enabled via --allow-redefinition-new. --local-partial-types must also be enabled.
This is still experimental and has known issues, so it's not documented anywhere. It works well enough that it can be used for non-trivial experimentation, however.
Closes #6233. Closes #6232. Closes #18568. Fixes #18619.
In this example, the type of x is inferred as int | str when using the new behavior:
Here is a summary of how it works:
There are some other known bugs and limitations:
In self check the feature generates 6 additional errors, which all seem correct -- we infer more precise types, which will generate additional errors due to invariant containers and fixing false negatives.
When type checking the largest internal codebase at Dropbox, this generated about 700 new errors, the vast majority of which seemed legitimate. Mostly they were due to inferring more precise types for variables that used to have Any types. I used a recent but not the latest version of the feature to type check the internal codebase.