BUG: Fix np.vecdot on empty object vectors returning None - #31033
Merged
seberg merged 2 commits intoMar 19, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
seberg
approved these changes
Mar 19, 2026
seberg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks, the fix looks good and test should be good enough as well. I checked that a.dot(a) does return 0 (it takes a different approach, as it fills the result with zero ahead of time, assuming that is OK). Also matmul() returns zero already.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Failed but unrelated. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They should be returning zero instead.
Fixes #31019