BUG: fix vdot returning None for empty object arrays - #31745
Closed
MeGaurav4 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
You ignored the PR template, so I'm going to assume that this PR has been made with agentic AI. We don't allow that here, because we prefer to talk to humans. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@jorenham My apologies for skipping the PR template — that was my mistake. You're right that agentic AI was involved in drafting this PR, and I should have disclosed that upfront and followed the template. I'll make sure to do so in future contributions. Thanks for your time reviewing. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.vdot on zero-length object arrays returns None instead of 0,
matching the same bug that was fixed in vecdot (#31033).
Add a zero-length guard in OBJECT_vdot to return PyLong_FromLong(0),
consistent with the numeric type behavior.
Closes #31735.