[SYCLomatic] null_type - #528
Merged
zhimingwang36 merged 1 commit intoFeb 16, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
|
|
||
| namespace dpct { | ||
|
|
||
| struct null_type {}; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
this PR doesn't show the use of null_type{}. So not sure how it is used and why it is necessary to add null_type.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I've just added a new PR into SYCLomatic-test which shows the intended usage of dpct::null_type.
oneapi-src/SYCLomatic-test#219
It will also likely be used in future dpct helper header APIs to a similar effect.
Sorry, something went wrong.
zhimingwang36
approved these changes
Feb 16, 2023
zhimingwang36
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
ShengchenJ
pushed a commit
to ShengchenJ/SYCLomatic
that referenced
this pull request
Sep 27, 2024
…i-src#528) Signed-off-by: Tang, Jiajun jiajun.tang@intel.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for dpct::null_type for to indicate the lack of argument.