This repository was archived by the owner on Jul 21, 2026. It is now read-only.
[SYCLomatic] Adding dpct::null_type test - #219
Merged
ShengchenJ merged 3 commits intoMar 31, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
yihwang-nv
reviewed
Feb 15, 2023
Comment thread
help_function/src/onedpl_test_null_type.cpp
Outdated
zhimingwang36
approved these changes
Feb 16, 2023
zhimingwang36
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
yihwang-nv
approved these changes
Mar 28, 2023
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM, can you please rebase this patch?
Sorry, something went wrong.
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger
force-pushed
the
dev/dhoeflin/null_type_test
branch
from
67cb0bc to
92118a4
Compare
March 28, 2023 12:31
Copy link
Copy Markdown
Contributor
Author
@yihanwg done |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The failing test for onedpl_test_copy_if is unrelated to this PR. At first glance, it looks related to what should be resolved by #243. |
Sorry, something went wrong.
ShengchenJ
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding example usage of dpct::null_type.
It is intended to be used to indicate that the argument is unused and does not need to be acted upon. Here we are redirecting to a key swap instead of a pair swap using metaprogramming when dpct::null_type is used for the value type.
This test requires oneapi-src/SYCLomatic#528 to be merged.