FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Handle octet-stream content media type as binary format by gudjonragnar · Pull Request #1418 · openapi-generators/openapi-python-client · GitHub

  1. openapi-generators
  2. openapi-python-client

Repository navigation

fix: Handle octet-stream content media type as binary format - #1418

Open
gudjonragnar wants to merge 2 commits into
openapi-generators:mainfrom
gudjonragnar:main
ConversationCommits (2)ChecksFiles changed
Open

fix: Handle octet-stream content media type as binary format#1418
gudjonragnar wants to merge 2 commits into
openapi-generators:mainfrom
gudjonragnar:main

Conversation

gudjonragnar commented Apr 7, 2026

Copy link
Copy Markdown

Fastapi fixed their spec generator to output contentMediaType: application/octet-stream instead of format: binary.
This results in a changed behaviour for the generated client when it comes to file uploads going from taking a File object to taking a string.
This patch should fix that.

gudjonragnar commented Apr 7, 2026

Copy link
Copy Markdown
Author

Not sure if this is the correct implementation since I am not very familiar with the code base, so very much open to changing it.

gudjonragnar changed the title Handle octet-stream content media type as binary format fix: Handle octet-stream content media type as binary format Apr 7, 2026
stephencattaneo mentioned this pull request May 8, 2026
Open

This comment was marked as off-topic.

Sign in to view

dhiganthrao commented Jul 8, 2026

Copy link
Copy Markdown

What's the status on this fix? I'm trying to update FastAPI in my application as well and am running into the same issue.

gudjonragnar commented Jul 9, 2026

Copy link
Copy Markdown
Author

What's the status on this fix? I'm trying to update FastAPI in my application as well and am running into the same issue.

🤷 For now im just using my fork. You could fork it yourself and depend on that directly until someone takes a look at this.

sindrig commented Aug 27, 2026

Copy link
Copy Markdown

Looks Good

@anmolbhat-jazzx did you mean to approve this PR? 🙂

jcschaff mentioned this pull request Sep 9, 2026
Merged
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
anmolbhat-jazzx anmolbhat-jazzx left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL