FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Handle octet-stream content media type as binary format by gudjonragnar · Pull Request #1418 · openapi-generators/openapi-python-client · GitHub

  1. openapi-generators
  2. openapi-python-client

Repository navigation

fix: Handle octet-stream content media type as binary format #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gudjonragnar wants to merge 2 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 5 Commits 2 Checks 1 Files changed
Open

fix: Handle octet-stream content media type as binary format #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de4249b
Handle octet-stream content media type as binary format
gudjonragnar Apr 7, 2026
fe2ed57
Merge branch 'openapi-generators:main' into main
gudjonragnar Jun 11, 2026
File filter

Filter by extension

Filter by extension .py  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
      • __init__.py
      • schema.py
2 changes: 1 addition & 1 deletion openapi_python_client/parser/properties/__init__.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def _string_based_property(
description=data.description,
example=data.example,
)
if string_format == "binary":
if string_format == "binary" or data.content_media_type == "application/octet-stream":
return FileProperty.build(
name=name,
required=required,
Expand Down
1 change: 1 addition & 0 deletions openapi_python_client/schema/openapi_schema_pydantic/schema.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ class Schema(BaseModel):
additionalProperties: bool | ReferenceOr["Schema"] | None = None
description: str | None = None
schema_format: str | None = Field(default=None, alias="format")
content_media_type: str | None = Field(default=None, alias="contentMediaType")
default: Any | None = None
nullable: bool = Field(default=False)
discriminator: Discriminator | None = None
Expand Down
30 changes: 30 additions & 0 deletions tests/test_parser/test_properties/test_init.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
build_schemas,
property_from_data,
)
from openapi_python_client.parser.properties.string import StringProperty
from openapi_python_client.schema import Parameter, Reference, Schema
from openapi_python_client.utils import ClassName, PythonIdentifier

Expand Down Expand Up @@ -223,6 +224,35 @@ def test__string_based_property_binary_format(self, file_property_factory, confi
)
assert p == file_property_factory(name=name, required=required)

@pytest.mark.parametrize(
"content_media_type,schema_format",
[
pytest.param("application/octet-stream", None, id="content-media-type-only"),
pytest.param("application/octet-stream", "binary", id="both-content-media-type-and-binary-format"),
],
)
def test__string_based_property_content_media_type(
self, file_property_factory, config, content_media_type, schema_format
):
name = "file_prop"
required = True
data = oai.Schema(type="string", contentMediaType=content_media_type, format=schema_format)

p, _ = property_from_data(
name=name, required=required, data=data, schemas=Schemas(), config=config, parent_name=""
)
assert p == file_property_factory(name=name, required=required)

def test__string_based_property_non_binary_content_media_type_ignored(self, config):
name = "text_prop"
required = True
data = oai.Schema(type="string", contentMediaType="text/plain")

p, _ = property_from_data(
name=name, required=required, data=data, schemas=Schemas(), config=config, parent_name=""
)
assert isinstance(p, StringProperty)


class TestCreateSchemas:
def test_dereference_references(self, mocker, config):
Expand Down
Back | FazBrowse Home | New Git URL