FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

⚠ make spec.namespace optional in the experimental channel by nader-ziada · Pull Request #2929 · operator-framework/operator-controller · GitHub

/ operator-controller Public

⚠ make spec.namespace optional in the experimental channel - #2929

Draft
nader-ziada wants to merge 2 commits into
operator-framework:mainfrom
nader-ziada:feat/optional-namespace-api
ConversationCommits (2)ChecksFiles changed
Draft

⚠ make spec.namespace optional in the experimental channel#2929
nader-ziada wants to merge 2 commits into
operator-framework:mainfrom
nader-ziada:feat/optional-namespace-api

Conversation

nader-ziada commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Description

Makes ClusterExtension.spec.namespace optional in the experimental API to support system-managed install namespaces.

When omitted, the controller uses the bundle’s system-managed namespace instead of requiring callers to provide one.

Changes

  • Marks spec.namespace optional in the experimental API and generated CRDs.
  • Updates API references and namespace-management documentation.
  • Adds admission coverage for omitted namespaces.
  • Adds e2e coverage for installing an extension without spec.namespace.
  • Updates generated apply configurations and CRD tooling.

Testing

  • Added/updated unit tests for API generation and admission validation.
  • Added namespace.feature e2e coverage for the omitted-namespace flow.

Depends on #2926 for the runtime handling of an omitted namespace.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

feat(applier): support a system-managed install namespace at runtime
9c32775 
When spec.namespace is empty the applier stops passing
WithSelfManagedInstallNamespace, so the renderer resolves the install namespace
from bundle metadata and emits the Namespace object itself. This is gated on
BoxcutterRuntime; with the gate off an empty spec.namespace is a terminal
configuration error rather than a silent fallback.

Signed-off-by: Nader Ziada <nziada@redhat.com>
feat(api): make spec.namespace optional in the experimental channel
2ac3035 
On the experimental channel spec.namespace may now be omitted, in which case
operator-controller resolves and creates a managed namespace from the bundle's
metadata. Whether the field is set or omitted is locked at creation time: it
cannot be added, removed, or changed afterwards. The standard channel keeps the
existing required and immutable contract.

Signed-off-by: Nader Ziada <nziada@redhat.com>
openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2026

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2ac3035
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6aac3040125c3500080155e7
😎 Deploy Preview https://deploy-preview-2929--olmv1.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

nader-ziada commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

/cc @joelanford @perdasilva pr #3

nader-ziada mentioned this pull request Sep 17, 2026
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL