FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Select): fix ListGroupItem import by glekner · Pull Request #1867 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Select): fix ListGroupItem import - #1867

Merged
jeff-phillips-18 merged 1 commit into
patternfly:masterfrom
glekner:fix-select-listitem
Apr 29, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(Select): fix ListGroupItem import#1867
jeff-phillips-18 merged 1 commit into
patternfly:masterfrom
glekner:fix-select-listitem

Conversation

glekner commented Apr 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What:
Select doesn't work downstream, due to a ListGroupItem import error, this PR tries to fix it.

patternfly-build commented Apr 28, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://1867-pr-patternfly-react-patternfly.surge.sh

codecov-io commented Apr 28, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1867 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1867   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files         623      623           
  Lines        6870     6870           
  Branches       93       93           
=======================================
  Hits         5676     5676           
  Misses       1154     1154           
  Partials       40       40
Flag Coverage Δ
#patternfly3 84.87% <100%> (ø) ⬆️
#patternfly4 79.37% <ø> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...y-react-extensions/src/components/Select/Select.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12dfa0...01df2aa. Read the comment docs.

glekner commented Apr 29, 2019

Copy link
Copy Markdown
Contributor Author

@jeff-phillips-18 thoughts on this? is this the right solution?

dgutride commented Apr 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@glekner - please open an issue for this

redallen approved these changes Apr 29, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should really fix the way we export ListGroupItem instead of this, but this will work for now.

jeff-phillips-18 commented Apr 29, 2019

Copy link
Copy Markdown
Member

This fix is correct given the current build. We should find a better way to build so that we can import with the previous syntax but currently this is how it needs to be.

jeff-phillips-18 merged commit f531e6b into patternfly:master Apr 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jeff-phillips-18 jeff-phillips-18 approved these changes
+1 more reviewer
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL