FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Select): fix ListGroupItem import by glekner · Pull Request #1867 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Select): fix ListGroupItem import #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeff-phillips-18 merged 1 commit into from
Apr 29, 2019
Conversation 6 Commits 1 Checks 0 Files changed
Merged

fix(Select): fix ListGroupItem import #1867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .js  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
14 changes: 7 additions & 7 deletions packages/patternfly-3/patternfly-react-extensions/src/components/Select/Select.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';
import PropTypes from 'prop-types';
import classNames from 'classnames';
import EllipsisWithTooltip from 'react-ellipsis-with-tooltip';
import { Spinner, Button, ListGroup, ListGroupItem, TypeAheadSelect } from 'patternfly-react';
import { Spinner, Button, ListGroup, TypeAheadSelect } from 'patternfly-react';
import { noop } from '../../common/helpers';
import { createItemProps } from './SelectHelper';
import SelectInput from './SelectInput';
Expand All @@ -29,20 +29,20 @@ const Select = ({

const renderResults = results =>
results.length === 0 ? (
<ListGroupItem id="select-empty" key="empty" className="select-empty-list">
<ListGroup.ListGroupItem id="select-empty" key="empty" className="select-empty-list">
<span id="empty-text">{emptyText}</span>
</ListGroupItem>
</ListGroup.ListGroupItem>
) : (
results.map((opt, i) => (
<ListGroupItem {...createItemProps(opt, selectedItem, opt.className || 'no-border', onItemClick)}>
<ListGroup.ListGroupItem {...createItemProps(opt, selectedItem, opt.className || 'no-border', onItemClick)}>
<EllipsisWithTooltip>
{searchValue && searchValue.length ? (
<TypeAheadSelect.Highlighter search={searchValue}>{opt.name}</TypeAheadSelect.Highlighter>
) : (
opt.name
)}
</EllipsisWithTooltip>
</ListGroupItem>
</ListGroup.ListGroupItem>
))
);

Expand Down Expand Up @@ -72,11 +72,11 @@ const Select = ({
)}
<ListGroup className="select-scrollable-list">
{isLoading ? (
<ListGroupItem id="select-loading" key="loading" className="select-loading-list">
<ListGroup.ListGroupItem id="select-loading" key="loading" className="select-loading-list">
<div id="select-loading-container">
<Spinner id="select-spinner" loading size="sm" /> <span>{loadingText}</span>
</div>
</ListGroupItem>
</ListGroup.ListGroupItem>
) : (
renderResults(options)
)}
Expand Down
Back | FazBrowse Home | New Git URL