FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(LoginPage): Convert LoginPage to typescript, add integration tests, and demo by jeff-phillips-18 · Pull Request #1967 · patternfly/patternfly-react · GitHub

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .jpg  (8) .js  (10) .md  (1) .snap  (9) .svg  (2) .ts  (17) .tsx  (22) All 7 file types selected
Deleted files Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
        • App.tsx
        • Demos.ts
            • LoginPageDemo.tsx
              • background-filter.svg
              • brandImgColor.svg
              • pfbg_1200.jpg
              • pfbg_2000.jpg
              • pfbg_576.jpg
              • pfbg_576@2x.jpg
              • pfbg_768.jpg
              • pfbg_768@2x.jpg
              • pfbg_992.jpg
              • pfbg_992@2x.jpg
          • index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { FunctionComponent, HTMLProps, ReactNode } from 'react';
export interface FormHelperTextProps extends HTMLProps<HTMLDivElement> {
children?: ReactNode;
isError?: boolean;
isActive?: boolean;
isHidden?: boolean;
className?: string;
}

declare const FormHelperText: FunctionComponent<FormHelperTextProps>;

export default FormHelperText;
export default FormHelperText;

This file was deleted.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React from 'react';
import * as React from 'react';
import { shallow } from 'enzyme';
import Login from './Login';
import LoginFooter from './LoginFooter';
import LoginHeader from './LoginHeader';
import { Login } from './Login';
import { LoginFooter } from './LoginFooter';
import { LoginHeader } from './LoginHeader';

test('Check login layout example against snapshot', () => {
const Header = <LoginHeader headerBrand="HeaderBrand">Header Text</LoginHeader>;
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -1,29 +1,25 @@
import React from 'react';
import * as React from 'react';
import styles from '@patternfly/patternfly/components/Login/login.css';
import { css } from '@patternfly/react-styles';
import PropTypes from 'prop-types';

const propTypes = {
export interface LoginProps extends React.HTMLProps<HTMLDivElement> {
/** Content rendered inside the main section of the login layout */
children: PropTypes.node,
children?: React.ReactNode;
/** Additional classes added to the login layout */
className: PropTypes.string,
className?: string;
/** Footer component (e.g. <LoginFooter />) */
footer: PropTypes.node,
footer?: React.ReactNode;
/** Header component (e.g. <LoginHeader />) */
header: PropTypes.node,
/** Additional props are spread to the container <div> */
'': PropTypes.any
};
header?: React.ReactNode;
}

const defaultProps = {
children: null,
className: '',
footer: null,
header: null
};

const Login = ({ className, children, footer, header, ...props }) => (
export const Login: React.FunctionComponent<LoginProps> = ({
className = '',
children = null,
footer = null,
header = null,
...props
}: LoginProps) => (
<div {...props} className={css(styles.login, className)}>
<div className={css(styles.loginContainer)}>
{header}
Expand All @@ -32,8 +28,3 @@ const Login = ({ className, children, footer, header, ...props }) => (
</div>
</div>
);

Login.propTypes = propTypes;
Login.defaultProps = defaultProps;

export default Login;

This file was deleted.

This file was deleted.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import * as React from 'react';
import styles from '@patternfly/patternfly/components/Login/login.css';
import { css } from '@patternfly/react-styles';

export interface LoginFooterProps extends React.HTMLProps<HTMLElement> {
/** Content rendered inside the footer of the login layout */
children?: React.ReactNode;
/** Additional props are spread to the container <footer> */
className?: string;
}

export const LoginFooter: React.FunctionComponent<LoginFooterProps> = ({
className = '',
children = null,
...props
}: LoginFooterProps) => (
<footer className={css(styles.loginFooter, className)} {...props}>
{children}
</footer>
);

This file was deleted.

This file was deleted.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import React from 'react';
import LoginFooterItem from './LoginFooterItem';
import * as React from 'react';
import { shallow } from 'enzyme';

import { LoginFooterItem } from './LoginFooterItem';

test('renders with PatternFly Core styles', () => {
const view = shallow(<LoginFooterItem target="_self" href="#" />);
expect(view).toMatchSnapshot();
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import * as React from 'react';

export interface LoginFooterItemProps extends React.HTMLProps<HTMLAnchorElement> {
/** Content rendered inside the footer Link Item */
children?: React.ReactNode;
/** Additional classes added to the Footer Link Item */
className?: string;
/** The URL of the Footer Link Item */
href?: string;
/** Specifies where to open the linked document */
target?: string;
}

export const LoginFooterItem: React.FunctionComponent<LoginFooterItemProps> = ({
className = '',
children = null,
href = '#',
target = '_blank',
...props
}: LoginFooterItemProps) => {
const reactElement: boolean = React.isValidElement(children);
return reactElement ? (
React.cloneElement(children as React.ReactElement<any>)
) : (
<a target={target} href={href} {...props}>
{children}
</a>
);
};

This file was deleted.

This file was deleted.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import * as React from 'react';
import { shallow } from 'enzyme';

import { LoginForm } from './LoginForm';

test('should render Login form', () => {
const view = shallow(<LoginForm />);
expect(view).toMatchSnapshot();
});

test('should call onChangeUsername callback', () => {
const mockFn = jest.fn();
const view = shallow(
<LoginForm onChangeUsername={mockFn} rememberMeLabel="Login Form" rememberMeAriaLabel="Login Form" />
);
view.find('#pf-login-username-id').simulate('change');
expect(mockFn).toHaveBeenCalled();
});

test('should call onChangePassword callback', () => {
const mockFn = jest.fn();
const view = shallow(
<LoginForm onChangePassword={mockFn} rememberMeLabel="Login Form" rememberMeAriaLabel="Login Form" />
);
view.find('#pf-login-password-id').simulate('change');
expect(mockFn).toHaveBeenCalled();
});

test('should call onChangeRememberMe callback', () => {
const mockFn = jest.fn();
const view = shallow(
<LoginForm onChangeRememberMe={mockFn} rememberMeLabel="Login Form" rememberMeAriaLabel="Login Form" />
);
view.find('#pf-login-remember-me-id').simulate('change');
expect(mockFn).toHaveBeenCalled();
});

test('LoginForm with rememberMeLabel and no rememberMeAriaLabel uses the rememberMeLabel', () => {
const view = shallow(<LoginForm rememberMeLabel="remember me" />);
expect(view).toMatchSnapshot();
});

test('LoginForm with rememberMeLabel and rememberMeAriaLabel uses the rememberMeAriaLabel', () => {
const view = shallow(
<LoginForm rememberMeAriaLabel="ARIA remember me" rememberMeLabel="remember me" />
);
expect(view).toMatchSnapshot();
});
Loading

Back | FazBrowse Home | New Git URL