feat(LoginPage): Convert LoginPage to typescript, add integration tests, and demo by jeff-phillips-18 · Pull Request #1967 · patternfly/patternfly-react · GitHub

What:

Convert LoginPage components to typescript
Add LoginPage to demo app
Add integration tests for LoginPage

fixes #1995

Codecov Report

Merging #1967 into master will decrease coverage by 0.42%.
The diff coverage is 65.32%.

@@            Coverage Diff            @@
##           master   #1967      +/-   ##
=========================================
- Coverage   82.33%   81.9%   -0.43%     
=========================================
  Files         628     628              
  Lines        6980    7053      +73     
  Branches      136     201      +65     
=========================================
+ Hits         5747    5777      +30     
- Misses       1161    1167       +6     
- Partials       72     109      +37

Flag	Coverage Δ
#patternfly3	84.88% <ø> (ø)	⬆️
#patternfly4	77.86% <65.32%> (-0.88%)	⬇️
#patternflymisc	95.68% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
...-core/src/components/LoginPage/LoginFooterItem.tsx	100% <100%> (ø)
.../components/LoginPage/LoginMainFooterLinksItem.tsx	100% <100%> (ø)
...c/components/LoginPage/LoginMainFooterBandItem.tsx	100% <100%> (ø)
.../react-core/src/components/LoginPage/LoginForm.tsx	55.17% <40.9%> (ø)
...eact-core/src/components/LoginPage/LoginHeader.tsx	44.44% <44.44%> (ø)
.../react-core/src/components/LoginPage/LoginPage.tsx	63.63% <45%> (ø)
...ly-4/react-core/src/components/LoginPage/Login.tsx	60% <50%> (ø)
...eact-core/src/components/LoginPage/LoginFooter.tsx	50% <50%> (ø)
...-core/src/components/LoginPage/LoginMainFooter.tsx	53.84% <50%> (ø)
...ct-core/src/components/LoginPage/LoginMainBody.tsx	87.5% <87.5%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4972cc3...fb2e632. Read the comment docs.

PatternFly-React preview: https://1967-pr-patternfly-react-patternfly.surge.sh

Change to }: LoginProps) => (

Remove all default exports.

Change to }: LoginFooterProps) => (

Change to }: LoginFooterItemProps) => {

Change to }: LoginFormProps) => ( and ditch the return.

Change to }: LoginMainFooterBandItemProps) => (

Change to }: LoginMainFooterLinksItemProps) => (

Change to }: LoginMainHeaderProps) => (

Change to }: LoginPageProps) => {

Great tests again. Thanks.

Do you need: typescript: true to show the TS badge?

Yep!

Can you please link the related issue here

I am not sure this will work for documentation due to the string in the union. We should update this to use the string values for BackgroundImageSrcMap.

@tlabaj My assumption, based on the code in BackgroundImage, is that there are potentially other strings that might be valid as wel (otherwise, why have the string | ?). I can change the BackgroundImageSrcMap part to list the options, but with any string being valid it will still show as union in the docs, correct?

Ye, that is my understanding as well.

so is it worth listing the values here? If it's going to say union anyhow, might as well use the enum here (I assume we would be using the enums everywhere if the docs worked correctly).

LGTM

@jeff-phillips-18 Looks good but there's a few conflicts now.

Rebased

Rerequesting review after updates.

LGTM

jeff-phillips-18 force-pushed the login-page-ts branch from f9c9a13 to 83debda Compare May 10, 2019 15:06

jeff-phillips-18 added PF4 labels May 10, 2019

jeff-phillips-18 force-pushed the login-page-ts branch from 83debda to 33f9fb0 Compare May 13, 2019 11:51

jeff-phillips-18 force-pushed the login-page-ts branch from 33f9fb0 to c7e93de Compare May 13, 2019 12:14

rachael-phillips mentioned this pull request May 13, 2019

Convert Login Page to TypeScript #1995

Closed

redallen previously requested changes May 15, 2019

View reviewed changes

dtaylor113 reviewed May 15, 2019

View reviewed changes

tlabaj reviewed May 15, 2019

View reviewed changes

tlabaj added the chore 🏠 label May 15, 2019

jeff-phillips-18 force-pushed the login-page-ts branch 2 times, most recently from 28a3144 to ba9d441 Compare May 16, 2019 18:40

tlabaj reviewed May 16, 2019

View reviewed changes

tlabaj previously approved these changes May 17, 2019

View reviewed changes

dtaylor113 previously approved these changes May 17, 2019

View reviewed changes

dlabaj previously approved these changes May 17, 2019

View reviewed changes

jeff-phillips-18 added 3 commits May 17, 2019 10:13

feat(Login Page): Convert Login Page component to typescript

fdb934a

Convert to typescript add demos and tests

b537085

Updates per review comments

fb2e632

jeff-phillips-18 dismissed stale reviews from dlabaj, dtaylor113, and tlabaj via fb2e632 May 17, 2019 14:18

jeff-phillips-18 force-pushed the login-page-ts branch from ba9d441 to fb2e632 Compare May 17, 2019 14:18

dlabaj requested a review from redallen May 17, 2019 14:36

dlabaj approved these changes May 17, 2019

View reviewed changes

tlabaj approved these changes May 17, 2019

View reviewed changes

tlabaj merged commit 4657da1 into patternfly:master May 17, 2019

jeff-phillips-18 deleted the login-page-ts branch May 12, 2022 12:00

+                footer = null,
+                header = null,
+                ...props
+              }) => (

+                className = '',
+                children = null,
+                ...props
+              }) => (

+                href = '#',
+                target = '_blank',
+                ...props
+              }) => {

+                onChangeRememberMe =  () => undefined,
+                rememberMeAriaLabel = '',
+                ...props
+              }) => {

+                children = null,
+                className = '',
+                ...props
+              }) => (

-              Login.propTypes = propTypes;
-              Login.defaultProps = defaultProps;
               export default Login;

+                title = '',
+                subtitle = '',
+                ...props
+              }) => (

+                forgotCredentials = null,
+                socialMediaLoginContent = null,
                 ...props
               }) => {

+                    .then(userNameInput => expect(userNameInput.text()).to.equal(''));
+                  cy.get('input[name="pf-login-password-id"]')
+                    .then(passwordInput => expect(passwordInput.text()).to.equal(''));
+                  cy.get('#pf-login-remember-me-id')

		@@ -7,6 +7,6 @@ import LinkPreview from '@content/../LinkPreview';
		import RawSimpleLoginPage from '!!raw-loader!./examples/SimpleLoginPage';

-                    filter: PropTypes.string
-                  })
-                ]),
+                backgroundImgSrc?: string | BackgroundImageSrcMap;

feat(LoginPage): Convert LoginPage to typescript, add integration tests, and demo by jeff-phillips-18 · Pull Request #1967 · patternfly/patternfly-react · GitHub

Uh oh!

feat(LoginPage): Convert LoginPage to typescript, add integration tests, and demo - #1967

feat(LoginPage): Convert LoginPage to typescript, add integration tests, and demo#1967tlabaj merged 3 commits intopatternfly:masterpatternfly/patternfly-react:masterfrom jeff-phillips-18:login-page-tsjeff-phillips-18/patternfly-react:login-page-tsCopy head branch name to clipboard

Conversation

jeff-phillips-18 commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented May 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

patternfly-build commented May 13, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

dlabaj commented May 17, 2019

Uh oh!

jeff-phillips-18 commented May 17, 2019

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

feat(LoginPage): Convert LoginPage to typescript, add integration tests, and demo#1967
tlabaj merged 3 commits into
patternfly:masterfrom
jeff-phillips-18:login-page-ts

jeff-phillips-18 commented May 10, 2019 •
edited
Loading

codecov-io commented May 10, 2019 •
edited
Loading