FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Badge): Convert badge to typescript by jessiehuff · Pull Request #2048 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Badge): Convert badge to typescript - #2048

Merged
redallen merged 2 commits into
patternfly:masterfrom
jessiehuff:feat/badgeTS
May 21, 2019
ConversationCommits (2)ChecksFiles changed
Merged

feat(Badge): Convert badge to typescript#2048
redallen merged 2 commits into
patternfly:masterfrom
jessiehuff:feat/badgeTS

Conversation

jessiehuff commented May 21, 2019

Copy link
Copy Markdown
Contributor

Fixes #1986

patternfly-build commented May 21, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2048-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 21, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2048 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
+ Coverage   81.92%   81.92%   +<.01%     
==========================================
  Files         632      632              
  Lines        7279     7280       +1     
  Branches      337      338       +1     
==========================================
+ Hits         5963     5964       +1     
  Misses       1164     1164              
  Partials      152      152
Flag Coverage Δ
#patternfly3 84.88% <ø> (ø) ⬆️
#patternfly4 78.16% <100%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Badge/Badge.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b070e65...f435407. Read the comment docs.

codecov-io commented May 21, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@b070e65). Click here to learn what that means.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master    #2048   +/-   ##
=========================================
  Coverage          ?   81.85%           
=========================================
  Files             ?      632           
  Lines             ?     7342           
  Branches          ?      364           
=========================================
  Hits              ?     6010           
  Misses            ?     1163           
  Partials          ?      169
Flag Coverage Δ
#patternfly3 84.88% <ø> (?)
#patternfly4 78.09% <66.66%> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...ernfly-4/react-core/src/components/Badge/Badge.tsx 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b070e65...2fa97f5. Read the comment docs.

redallen suggested changes May 21, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also add typescript: true to the md because I think it looks pretty :)

Comment thread packages/patternfly-4/react-core/src/components/Badge/Badge.tsx Outdated
dlabaj approved these changes May 21, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen commented May 21, 2019

Copy link
Copy Markdown
Contributor

It looks very pretty.

redallen merged commit 836f484 into patternfly:master May 21, 2019
rachael-phillips added this to the Albatross milestone May 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+1 more reviewer
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Albatross

Development

Successfully merging this pull request may close these issues.

Convert badge component to typescript

6 participants

Back | FazBrowse Home | New Git URL