FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Badge): Convert badge to typescript by jessiehuff · Pull Request #2048 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Badge): Convert badge to typescript #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 2 commits into from
May 21, 2019
Conversation 7 Commits 2 Checks 0 Files changed
Merged

feat(Badge): Convert badge to typescript #2048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f435407
Convert badge to typescript
jessiehuff May 21, 2019
2fa97f5
Fix default props
jessiehuff May 21, 2019
File filter

Filter by extension

Filter by extension .js  (2) .md  (1) .snap  (1) .ts  (6) .tsx  (3) All 5 file types selected
Deleted files Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
      • Badge.d.ts
      • Badge.js
      • Badge.md
      • Badge.test.tsx
      • Badge.tsx
        • Badge.test.tsx.snap
      • index.d.ts
      • index.js
      • index.ts
        • badge.spec.ts
        • Demos.ts
            • BadgeDemo.tsx
          • index.ts
10 changes: 0 additions & 10 deletions packages/patternfly-4/react-core/src/components/Badge/Badge.d.ts
Show comments
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions packages/patternfly-4/react-core/src/components/Badge/Badge.js
Show comments
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions packages/patternfly-4/react-core/src/components/Badge/Badge.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
title: 'Badge'
cssPrefix: 'pf-c-badge'
typescript: true
---
import { Badge } from '@patternfly/react-core';

Expand Down
2 changes: 1 addition & 1 deletion ...t-core/src/components/Badge/Badge.test.js → ...-core/src/components/Badge/Badge.test.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Badge from './Badge';
import { Badge } from './Badge';
import React from 'react';
import { shallow } from 'enzyme';

Expand Down
22 changes: 22 additions & 0 deletions packages/patternfly-4/react-core/src/components/Badge/Badge.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import * as React from 'react';
import { css } from '@patternfly/react-styles';
import styles from '@patternfly/patternfly/components/Badge/badge.css';

export interface BadgeProps extends React.HTMLProps<HTMLSpanElement> {
/** Adds styling to the badge to indicate it has been read */
isRead?: boolean;
/** content rendered inside the Badge */
children?: React.ReactNode;
/** additional classes added to the Badge */
className?: string;
}

export const Badge: React.FunctionComponent<BadgeProps> = ({
isRead = false,
className = '',
children = '',
...props }: BadgeProps) => (
<span {...props} className={css(styles.badge, (isRead ? styles.modifiers.read : styles.modifiers.unread) as any, className)}>
{children}
</span>
);
0 ...ts/Badge/__snapshots__/Badge.test.js.snap → ...s/Badge/__snapshots__/Badge.test.tsx.snap
Show comments
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion packages/patternfly-4/react-core/src/components/Badge/index.d.ts
Show comments
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/patternfly-4/react-core/src/components/Badge/index.js
Show comments
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions packages/patternfly-4/react-core/src/components/Badge/index.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './Badge';
15 changes: 15 additions & 0 deletions packages/patternfly-4/react-integration/cypress/integration/badge.spec.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
describe('Badge Demo Test', () => {
it('Navigate to demo section', () => {
cy.visit('http://localhost:3000/');
cy.get('#badge-demo-nav-item-link').click();
cy.url().should('eq', 'http://localhost:3000/badge-demo-nav-link');
});

it('Verify badge is unread', () => {
cy.get('.pf-c-badge').should('have.class', 'pf-m-unread')
});

it('Verify default badge', () => {
cy.get('.pf-c-badge').contains('7')
});
})
5 changes: 5 additions & 0 deletions packages/patternfly-4/react-integration/demo-app-ts/src/Demos.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ export const Demos: DemoInterface[] = [
name: 'Avatar Demo',
componentType: Examples.AvatarDemo
},
{
id: 'badge-demo',
name: 'Badge Demo',
componentType: Examples.BadgeDemo
},
{
id: 'brand-demo',
name: 'Brand Demo',
Expand Down
15 changes: 15 additions & 0 deletions ...s/patternfly-4/react-integration/demo-app-ts/src/components/demos/BadgeDemo/BadgeDemo.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import React from 'react';
import { Badge } from '@patternfly/react-core';

export class BadgeDemo extends React.Component {
render() {
return (
<React.Fragment>
<Badge isRead={false}>7</Badge>
<Badge isRead={false}>24</Badge>
<Badge isRead={false}>240</Badge>
<Badge isRead={false}>999+</Badge>
</React.Fragment>
)
}
}
1 change: 1 addition & 0 deletions packages/patternfly-4/react-integration/demo-app-ts/src/components/demos/index.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export * from './AlertDemo/AlertDemo';
export * from './AvatarDemo/AvatarDemo';
export * from './BadgeDemo/BadgeDemo';
export * from './BrandDemo/BrandDemo';
export * from './BreadcrumbDemo/BreadcrumbDemo';
export * from './ButtonDemo/ButtonDemo';
Expand Down
Back | FazBrowse Home | New Git URL