FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(react-styles): move react styles by redallen · Pull Request #2085 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(react-styles): move react styles - #2085

Merged
dlabaj merged 28 commits into
patternfly:masterfrom
dgutride:move-styles
Jun 5, 2019
ConversationCommits (28)ChecksFiles changed
Merged

feat(react-styles): move react styles#2085
dlabaj merged 28 commits into
patternfly:masterfrom
dgutride:move-styles

Conversation

redallen commented May 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Change all the React css imports and add types for them. Instead of using a babel plugin to generate the JS at compile time for our CSS-in-JS solution, we statically generate it beforehand in react-styles.

Additional issues:

patternfly-build commented May 24, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2085-pr-patternfly-react-patternfly.surge.sh

codecov-io commented May 24, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2085 into master will increase coverage by 0.52%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
+ Coverage   80.31%   80.83%   +0.52%     
==========================================
  Files         651      651              
  Lines        8300     8260      -40     
  Branches      628      628              
==========================================
+ Hits         6666     6677      +11     
+ Misses       1333     1282      -51     
  Partials      301      301
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 76.45% <100%> (+0.97%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/scripts/snapshot-serializer.js 100% <ø> (ø)
...4/react-core/src/components/Select/SingleSelect.js 81.25% <ø> (ø) ⬆️
...rc/components/Table/utils/decorators/classNames.js 75% <ø> (ø) ⬆️
...atternfly-4/react-core/src/components/Tabs/Tabs.js 80.76% <ø> (ø) ⬆️
...react-core/src/components/DataList/DataListCell.js 100% <ø> (ø) ⬆️
...-4/react-core/src/components/Dropdown/Separator.js 100% <ø> (ø) ⬆️
...act-core/src/components/Dropdown/DropdownToggle.js 85.71% <ø> (ø) ⬆️
...rnfly-4/react-core/src/components/Select/Select.js 58% <ø> (ø) ⬆️
...ponents/ApplicationLauncher/ApplicationLauncher.js 50% <ø> (ø) ⬆️
...ct-core/src/components/ClipboardCopy/CopyButton.js 100% <ø> (ø) ⬆️
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b4d91...6531d73. Read the comment docs.

dlabaj previously approved these changes May 28, 2019
View reviewed changes

dlabaj commented May 28, 2019

Copy link
Copy Markdown
Contributor

@redallen Looks like there's a conflict with .babelrc

patternfly-build commented Jun 5, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2085-pr-patternfly-react-patternfly.surge.sh

dlabaj merged commit 81d1ed2 into patternfly:master Jun 5, 2019
redallen mentioned this pull request Jun 7, 2019
Merged
ssilvert mentioned this pull request Aug 8, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+1 more reviewer
dgutride dgutride approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL