build(esm): fix esm output and convert react-virtualized-extension to TS - #2190
Merged
priley86 merged 6 commits intoJun 10, 2019
Merged
build(esm): fix esm output and convert react-virtualized-extension to TS#2190priley86 merged 6 commits into
priley86 merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://2190-pr-patternfly-react-patternfly.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
=========================================
Coverage ? 85.49%
=========================================
Files ? 370
Lines ? 4040
Branches ? 0
=========================================
Hits ? 3454
Misses ? 586
Partials ? 0
Continue to review full report at Codecov.
|
Sorry, something went wrong.
dgutride
reviewed
Jun 8, 2019
Comment thread
packages/patternfly-4/react-core/.babelrc.js
Copy link
Copy Markdown
Member
|
thanks @redallen ! will try to test this out this week. |
Sorry, something went wrong.
dgutride
approved these changes
Jun 10, 2019
priley86
approved these changes
Jun 10, 2019
This was referenced Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fix recent regression from #2085 that made our dist only commons JS for a few packages. Clean babelrc.js and babel build targets to be consistent across packages. Fix jest config afterwards.
Additional issues: