FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(refs): fix ref proptypes by redallen · Pull Request #2136 · patternfly/patternfly-react · GitHub

fix(refs): fix ref proptypes - #2136

Closed
redallen wants to merge 2 commits into
patternfly:masterfrom
redallen:fix/ref-proptypes
Closed

fix(refs): fix ref proptypes#2136
redallen wants to merge 2 commits into
patternfly:masterfrom
redallen:fix/ref-proptypes

Conversation

redallen commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

What: Fixes #2132

Additional issues:

codecov-io commented Jun 3, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2136 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2136      +/-   ##
==========================================
+ Coverage   80.96%   80.96%   +<.01%     
==========================================
  Files         649      649              
  Lines        7885     7886       +1     
  Branches      505      505              
==========================================
+ Hits         6384     6385       +1     
  Misses       1261     1261              
  Partials      240      240
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 76.28% <100%> (ø) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...4/react-core/src/components/Select/SelectOption.js 60% <ø> (ø) ⬆️
...core/src/components/Select/CheckboxSelectOption.js 40% <ø> (ø) ⬆️
...react-core/src/components/Dropdown/DropdownItem.js 57.14% <ø> (ø) ⬆️
.../react-core/src/components/Dropdown/KebabToggle.js 100% <ø> (ø) ⬆️
...4/react-core/src/components/Select/SelectToggle.js 54.54% <ø> (ø) ⬆️
...fly-4/react-core/src/components/Dropdown/Toggle.js 58.62% <ø> (ø) ⬆️
...fly-4/react-core/src/components/Tabs/TabContent.js 83.33% <ø> (ø) ⬆️
...-core/src/components/ApplicationLauncher/Toggle.js 13.79% <ø> (ø) ⬆️
...act-core/src/components/Dropdown/DropdownToggle.js 85.71% <ø> (ø) ⬆️
.../components/ContextSelector/ContextSelectorItem.js 100% <ø> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7495082...e38fbaf. Read the comment docs.

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2136-pr-patternfly-react-patternfly.surge.sh

tlabaj commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

closing this as issue #2132 was closed by PR #2158

tlabaj closed this Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PF4 Tabs Invalid prop forwardRef supplied to Tab

4 participants


Back | FazBrowse Home | New Git URL