FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix tabs ref proptype by jschuler · Pull Request #2158 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix tabs ref proptype - #2158

Merged
dlabaj merged 2 commits into
patternfly:masterfrom
jschuler:tabs-fix
Jun 5, 2019
ConversationCommits (2)ChecksFiles changed
Merged

fix tabs ref proptype#2158
dlabaj merged 2 commits into
patternfly:masterfrom
jschuler:tabs-fix

Conversation

jschuler commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

Closes: #2151 #2132

codecov-io commented Jun 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2158 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2158      +/-   ##
==========================================
+ Coverage   80.49%   80.51%   +0.01%     
==========================================
  Files         649      649              
  Lines        8225     8225              
  Branches      610      610              
==========================================
+ Hits         6621     6622       +1     
+ Misses       1308     1307       -1     
  Partials      296      296
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 75.77% <100%> (+0.02%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...fly-4/react-core/src/components/Tabs/TabContent.js 83.33% <ø> (ø) ⬆️
...patternfly-4/react-core/src/components/Tabs/Tab.js 100% <100%> (ø) ⬆️
...atternfly-4/react-core/src/components/Tabs/Tabs.js 80.76% <0%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cbc01f...98e6d22. Read the comment docs.

patternfly-build commented Jun 4, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2158-pr-patternfly-react-patternfly.surge.sh

tlabaj approved these changes Jun 4, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jschuler commented Jun 4, 2019

Copy link
Copy Markdown
Contributor Author

Closing i think there is still an issue left. will reopen when ready

jschuler closed this Jun 4, 2019
jschuler reopened this Jun 5, 2019

jschuler commented Jun 5, 2019

Copy link
Copy Markdown
Contributor Author

It's good to merge as is

dlabaj merged commit e28c44d into patternfly:master Jun 5, 2019
tlabaj mentioned this pull request Jun 5, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+1 more reviewer
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RC2: Tabs: Invalid props 'forwardRef'

5 participants

Back | FazBrowse Home | New Git URL