FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Chart): Fix runtime errors related to theme padding by TheRealJon · Pull Request #2430 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Chart): Fix runtime errors related to theme padding - #2430

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
TheRealJon:issue-2429
Jul 2, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(Chart): Fix runtime errors related to theme padding#2430
tlabaj merged 1 commit into
patternfly:masterfrom
TheRealJon:issue-2429

Conversation

TheRealJon commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Add more robust logic for setting padding values in Chart component

fix #2429

What:

  • Add new util function for getting padding values from props and falling back to the theme
  • Use new util function in Chart component to get default padding values

fix(Chart): Fix runtime errors related to theme padding
c78af03 
Add more robust logic for setting padding values in Chart component

fix #2429
TheRealJon requested a review from dlabrecq July 2, 2019 17:11

patternfly-build commented Jul 2, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2430.surge.sh

TheRealJon requested a review from dgutride July 2, 2019 17:25
tlabaj approved these changes Jul 2, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit a4d9f75 into patternfly:master Jul 2, 2019
TheRealJon deleted the issue-2429 branch July 2, 2019 17:35
redallen mentioned this pull request Jul 2, 2019
Merged

redallen commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Your changes have been released in:

  • @patternfly/react-charts@4.4.7

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabrecq Awaiting requested review from dlabrecq
2 more reviewers
dgutride dgutride approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug(Chart component): Malformed padding causes runtime errors

5 participants

Back | FazBrowse Home | New Git URL