Update chart theme to use pf-core variables - #2439
Merged
tlabaj merged 2 commits intoJul 3, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
fixes patternfly#2437 (cherry picked from commit 73ff63b)
dlabrecq
force-pushed
the
2280-core-vars
branch
2 times, most recently
from
c6eb4d4 to
203eb33
Compare
July 3, 2019 04:14
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2439.surge.sh |
Sorry, something went wrong.
redallen
approved these changes
Jul 3, 2019
jcaianirh
approved these changes
Jul 3, 2019
jcaianirh
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
tlabaj
approved these changes
Jul 3, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the chart theme to use pf-core vars -- the majority of changes are to base-theme.ts.
Also adds some padding to chart examples to address #2438.
fixes #2280
fixes #2438
A couple minor pf-core tweaks will need to be added in a later PR.
patternfly/patternfly#2011