Blue_300 & Purple_300 are too similar reordering for more contrast - #2544
Blue_300 & Purple_300 are too similar reordering for more contrast#2544AllenBW wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
PatternFly-React preview: https://patternfly-react-pr-2544.surge.sh |
Sorry, something went wrong.
There was a problem hiding this comment.
This may work for a donut with 4 data points, but not sure about other scenarios? Is this the correct color contrast we need for all possible colors?
Feels like we may be rushing a fix here? IMO, we should allow the design team to define a proper color order.
We may still want the first color to be organized by color families? See patternfly/patternfly#1551
Alternatively, we could move the purple color family between yellow and green for more buffer — on a per-chart basis? Or, simply omit the purple color family (my pref) — that would ensure contrast.
Making the white borders larger is also a possibility.
//cc @mceledonia
Sorry, something went wrong.
|
gotta update on this, not gonna go this direction, https://patternfly.slack.com/archives/CL6EU2526/p1563544432084900 @dlabrecq wants to to apply a new, second multi-color theme in a certain way for ordered charts |
Sorry, something went wrong.
|
I'm creating a new, second multi-color theme specifically designed for ordered charts such as donut, pie, bar, etc. See #2550 |
Sorry, something went wrong.
What:
Blue_300 & Purple_300 are too similar for a 4 item donut reordering for additional contrast
now we'd need an 8 item donut before this issue arises again 😏
Looks like (now)
Looked like (then)
what it might look like with eight 😱