FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(charts): added new mutil-color theme for ordered charts by dlabrecq · Pull Request #2552 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(charts): added new mutil-color theme for ordered charts - #2552

Merged
dlabrecq merged 2 commits into
patternfly:masterfrom
dlabrecq:2550-multi-ordered-theme
Jul 22, 2019
ConversationCommits (2)ChecksFiles changed
Merged

feat(charts): added new mutil-color theme for ordered charts#2552
dlabrecq merged 2 commits into
patternfly:masterfrom
dlabrecq:2550-multi-ordered-theme

Conversation

dlabrecq commented Jul 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Created a new, mutil-color theme specifically for ordered charts; donut, pie, bar, & stack. The existing multi-color theme will continue to be used for unordered charts; area & line.

To avoid a breaking change, ChartThemeColor.multi defaults to the ChartThemeColor.multiOrdered theme, since area/line are the only unordered charts.

Fixes #2550

dlabrecq requested a review from AllenBW July 19, 2019 16:03

patternfly-build commented Jul 19, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2552.surge.sh

dlabrecq force-pushed the 2550-multi-ordered-theme branch from c4e670a to b6be1c0 Compare July 19, 2019 16:10
dlabrecq requested a review from mceledonia July 19, 2019 16:11
dlabrecq force-pushed the 2550-multi-ordered-theme branch from b6be1c0 to aaca061 Compare July 19, 2019 16:25

AllenBW commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

read my mind, documentation for ordered and un <3

AllenBW approved these changes Jul 19, 2019
View reviewed changes

AllenBW left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FANTASTIC!! Just what the 👩‍⚕ ordered (ordered 😏 )

AllenBW mentioned this pull request Jul 19, 2019
Closed
mceledonia approved these changes Jul 19, 2019
View reviewed changes

mceledonia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great, thanks Dan!

redallen approved these changes Jul 19, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I like purple, but it's true the contrast with blue isn't that great 👍

dlabrecq merged commit 8ab3844 into patternfly:master Jul 22, 2019

patternfly-build commented Jul 22, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@4.7.0
  • @patternfly/react-core@3.74.0
  • @patternfly/react-docs@4.8.83
  • @patternfly/react-inline-edit-extension@2.9.46
  • demo-app-ts@2.12.8
  • @patternfly/react-table@2.14.20
  • @patternfly/react-topology@2.6.17
  • @patternfly/react-virtualized-extension@1.1.79

Thanks for your contribution! 🎉

priley86 commented Jul 23, 2019

Copy link
Copy Markdown
Member

thanks for this contribution @dlabrecq ! I don't think we'll have a chance to pull this in immediately in Subscriptions, but we've filed an issue today:
https://github.com/RedHatInsights/curiosity-frontend/issues/51

Will bounce back if I have any problems!

dlabrecq deleted the 2550-multi-ordered-theme branch July 24, 2019 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
AllenBW AllenBW approved these changes
dgutride dgutride approved these changes
mceledonia mceledonia approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create new mutil-color theme for ordered charts

7 participants

Back | FazBrowse Home | New Git URL