FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump @patternfly/patternfly to 2.23.0, add promotion script, add bumping script by redallen · Pull Request #2549 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Bump @patternfly/patternfly to 2.23.0, add promotion script, add bumping script - #2549

Merged
tlabaj merged 5 commits into
patternfly:masterfrom
redallen:chore/promotion-script
Jul 24, 2019
ConversationCommits (5)ChecksFiles changed
Merged

Bump @patternfly/patternfly to 2.23.0, add promotion script, add bumping script#2549
tlabaj merged 5 commits into
patternfly:masterfrom
redallen:chore/promotion-script

Conversation

redallen commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

What: Closes #2336 .

Additional issues: Still requires manually running each command for now to build some trust around a sensitive process.

redallen mentioned this pull request Jul 19, 2019
Closed

patternfly-build commented Jul 19, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2549.surge.sh

dlabrecq previously approved these changes Jul 22, 2019
View reviewed changes
redallen changed the title add promotion script Bump @patternfly/patternfly to 2.23.0, add promotion script Jul 23, 2019
redallen changed the title Bump @patternfly/patternfly to 2.23.0, add promotion script Bump @patternfly/patternfly to 2.23.0, add promotion script, add bumping script Jul 23, 2019
redallen changed the title Bump @patternfly/patternfly to 2.23.0, add promotion script, add bumping script Bump @patternfly/patternfly to 2.23.0add promotion script, add bumping script Jul 23, 2019
redallen changed the title Bump @patternfly/patternfly to 2.23.0add promotion script, add bumping script Bump @patternfly/patternfly to 2.23.0, add promotion script, add bumping script Jul 23, 2019
jenny-s51 self-requested a review July 24, 2019 13:08
jenny-s51 approved these changes Jul 24, 2019
View reviewed changes

jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for working on this, Zack!

jenny-s51 mentioned this pull request Jul 24, 2019
Merged
tlabaj approved these changes Jul 24, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj suggested changes Jul 24, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

are the additional changes need for PR?

dgutride mentioned this pull request Jul 24, 2019
Closed

redallen commented Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

@tlabaj I'd argue the bumping script belongs here, and the promotion script is an appropriate nice-to-have since we are about to promote. None of these affect our packages.

tlabaj approved these changes Jul 24, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 81bd279 into patternfly:master Jul 24, 2019

patternfly-build commented Jul 24, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@4.7.1
  • @patternfly/react-core@3.75.2
  • @patternfly/react-docs@4.9.2
  • @patternfly/react-inline-edit-extension@2.9.49
  • demo-app-ts@2.12.11
  • @patternfly/react-styled-system@3.6.17
  • @patternfly/react-styles@3.5.7
  • @patternfly/react-table@2.14.23
  • @patternfly/react-tokens@2.6.13
  • @patternfly/react-topology@2.6.20
  • @patternfly/react-virtualized-extension@1.1.82
  • @patternfly/react-icons@3.10.14

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dgutride Awaiting requested review from dgutride
jschuler Awaiting requested review from jschuler
3 more reviewers
jenny-s51 jenny-s51 approved these changes
tlabaj tlabaj approved these changes
dlabrecq dlabrecq left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spike: Investigating release automation

5 participants

Back | FazBrowse Home | New Git URL