FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(select): select menu has consistent behavior on input field by jenny-s51 · Pull Request #2572 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(select): select menu has consistent behavior on input field - #2572

Merged
redallen merged 5 commits into
patternfly:masterfrom
jenny-s51:iss2561
Jul 25, 2019
ConversationCommits (5)ChecksFiles changed
Merged

fix(select): select menu has consistent behavior on input field #2572
redallen merged 5 commits into
patternfly:masterfrom
jenny-s51:iss2561

Conversation

jenny-s51 commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

What: Closes #2561. Select menu now has consistent, open behavior on empty text input field. This is the expected default behavior per @mcarrano's feedback.

jenny-s51 requested review from kmcfaul, mcarrano and tlabaj July 23, 2019 14:38
jenny-s51 self-assigned this Jul 23, 2019

patternfly-build commented Jul 23, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2572.surge.sh

redallen approved these changes Jul 23, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Works when I tab to it and makes sense.

mcarrano previously requested changes Jul 23, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@jenny-s51 I still am having problems getting the text insertion cursor when I click on the input field for type-ahead select.

jenny-s51 commented Jul 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@mcarrano this is because the react workspace is currently using an outdated version of core. The input field issue was fixed here by @mcoker patternfly/patternfly#2075, and is in a newer core release. As soon as @redallen 's PR #2549 is merged, the input field will work as expected.

jenny-s51 requested a review from mcarrano July 24, 2019 13:16
jenny-s51 dismissed mcarrano’s stale review July 25, 2019 14:02

Version bump has been merged.

mcarrano approved these changes Jul 25, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approved based on reviewing this link: https://patternfly-react.surge.sh/patternfly-4/components/select/

redallen merged commit f26c530 into patternfly:master Jul 25, 2019

patternfly-build commented Jul 25, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.77.1
  • @patternfly/react-docs@4.9.6
  • @patternfly/react-inline-edit-extension@2.9.53
  • demo-app-ts@2.13.1
  • @patternfly/react-table@2.15.1
  • @patternfly/react-topology@2.7.2
  • @patternfly/react-virtualized-extension@1.1.86

Thanks for your contribution! 🎉

tlabaj mentioned this pull request Jul 26, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kmcfaul kmcfaul approved these changes
tlabaj Awaiting requested review from tlabaj
+2 more reviewers
mcarrano mcarrano approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jenny-s51

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Select menu has incorrect closing behavior

6 participants

Back | FazBrowse Home | New Git URL