FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Spinner): Add Spinner to experimental by tlabaj · Pull Request #2858 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Spinner): Add Spinner to experimental - #2858

Merged
redallen merged 3 commits into
patternfly:masterfrom
tlabaj:spinner
Sep 6, 2019
ConversationCommits (3)ChecksFiles changed
Merged

feat(Spinner): Add Spinner to experimental#2858
redallen merged 3 commits into
patternfly:masterfrom
tlabaj:spinner

Conversation

tlabaj commented Sep 5, 2019 •
edited by redallen
Loading

Copy link
Copy Markdown
Contributor

Fixes #2753

What:

Additional issues:

patternfly-build commented Sep 5, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2858.surge.sh

mcoker commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

Hmm... for some reason the reset styles are being loaded after the component styles again. The global reset styles for background-color: transparent are overriding the background color for the lead/tail-ball elements, so the edges aren't rounded.

core

react

mcarrano reviewed Sep 5, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, but @mceledonia can you give this a look and let me know if this behaves as expected?

dlabaj previously approved these changes Sep 6, 2019
View reviewed changes
jessiehuff approved these changes Sep 6, 2019
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! :)

mcoker approved these changes Sep 6, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🏆

redallen approved these changes Sep 6, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/experimental/components/Spinner/Spinner.md
typescript: true
propComponents: ['Spinner']
section: 'experimental'
---

redallen Sep 6, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For this to show up properly on -org, we are using a new stage: 'early' in the frontmatter. I'll address this in a follow-up PR.

mceledonia commented Sep 6, 2019

Copy link
Copy Markdown

I'm getting rendering artifacts but I trust @redallen 's diagnosis of my gpu causing them! Other than that it looks great to me.

mcarrano removed the ux review label Sep 6, 2019
mcarrano approved these changes Sep 6, 2019
View reviewed changes

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If @mceledonia is good, then I'm good!

redallen merged commit 77afa63 into patternfly:master Sep 6, 2019

patternfly-build commented Sep 6, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.100.0
  • @patternfly/react-docs@4.12.0
  • @patternfly/react-inline-edit-extension@2.11.26
  • demo-app-ts@2.23.0
  • @patternfly/react-integration@2.23.0
  • @patternfly/react-table@2.20.6
  • @patternfly/react-topology@2.8.25
  • @patternfly/react-virtualized-extension@1.2.14

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
mcoker mcoker approved these changes
kmcfaul Awaiting requested review from kmcfaul
+3 more reviewers
mcarrano mcarrano approved these changes
jessiehuff jessiehuff approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spinner

8 participants

Back | FazBrowse Home | New Git URL