- Notifications You must be signed in to change notification settings
- Fork 392
Additional navigation options
feat(Spinner): Add Spinner to experimental #2858
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
Filter by extension
Filter by extension
.js
(2)
.md
(1)
.snap
(1)
.ts
(5)
.tsx
(3)
All 5 file types selected
Viewed files
Viewed files
Conversations
Jump to
Failed to load comments.
Loading
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
-
-
-
- packages/patternfly-4/react-core/src/experimental/components/Spinner/Spinner.md Spinner.md
- packages/patternfly-4/react-core/src/experimental/components/Spinner/Spinner.test.tsx Spinner.test.tsx
- packages/patternfly-4/react-core/src/experimental/components/Spinner/Spinner.tsx Spinner.tsx
-
- packages/patternfly-4/react-core/src/experimental/components/Spinner/__snapshots__/Spinner.test.tsx.snap Spinner.test.tsx.snap
- packages/patternfly-4/react-core/src/experimental/components/Spinner/index.ts index.ts
- packages/patternfly-4/react-core/src/experimental/components/index.ts index.ts
-
-
- packages/patternfly-4/react-docs/.eslintrc.js .eslintrc.js
- packages/patternfly-4/react-docs/gatsby-browser.js gatsby-browser.js
-
-
- packages/patternfly-4/react-integration/cypress/integration/spinner.spec.ts spinner.spec.ts
-
- packages/patternfly-4/react-integration/demo-app-ts/src/Demos.ts Demos.ts
-
-
- packages/patternfly-4/react-integration/demo-app-ts/src/components/demos/SpinnerDemo/SpinnerDemo.tsx SpinnerDemo.tsx
- packages/patternfly-4/react-integration/demo-app-ts/src/components/demos/index.ts index.ts
-
-
-
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
packages/patternfly-4/react-core/src/experimental/components/Spinner/Spinner.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| title: 'Spinner' | ||
| cssPrefix: 'pf-c-spinner' | ||
| typescript: true | ||
| propComponents: ['Spinner'] | ||
| section: 'experimental' | ||
| --- | ||
|
|
||
| import { Spinner } from '@patternfly/react-core/dist/esm/experimental'; | ||
| import { Alert } from '@patternfly/react-core'; | ||
|
|
||
| <Alert variant="danger" title="Warning"> | ||
| Use this component at your own risk, it's currently under development and is subject | ||
| to change. | ||
| </Alert> | ||
|
|
||
| ## Spinner | ||
|
|
||
| ```js | ||
| import React from 'react'; | ||
| import { Spinner } from '@patternfly/react-core/dist/esm/experimental'; | ||
|
|
||
| SpinnerSimple = () => (<Spinner/>); | ||
| ``` | ||
|
|
||
| # Spinner size variations | ||
|
|
||
| ```js | ||
| import React from 'react'; | ||
| import { Spinner } from '@patternfly/react-core/dist/esm/experimental'; | ||
|
|
||
| SpinnerSizeVariations = () => ( | ||
| <React.Fragment> | ||
| <Spinner size="sm"/> | ||
| <Spinner size="md"/> | ||
| <Spinner size="lg"/> | ||
| <Spinner size="xl"/> | ||
| </React.Fragment> | ||
| ); | ||
| ``` | ||
28 changes: 28 additions & 0 deletions
28
packages/patternfly-4/react-core/src/experimental/components/Spinner/Spinner.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import * as React from 'react'; | ||
| import { shallow } from 'enzyme'; | ||
| import { Spinner } from './Spinner'; | ||
|
|
||
| test('simple spinner', () => { | ||
| const view = shallow(<Spinner/>); | ||
| expect(view).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test('small spinner', () => { | ||
| const view = shallow(<Spinner/>); | ||
| expect(view).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test('medium spinner', () => { | ||
| const view = shallow(<Spinner/>); | ||
| expect(view).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test('large spinner', () => { | ||
| const view = shallow(<Spinner/>); | ||
| expect(view).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test('extra large spinner', () => { | ||
| const view = shallow(<Spinner/>); | ||
| expect(view).toMatchSnapshot(); | ||
| }); |
39 changes: 39 additions & 0 deletions
39
packages/patternfly-4/react-core/src/experimental/components/Spinner/Spinner.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import * as React from 'react'; | ||
| import styles from '@patternfly/react-styles/css/components/Spinner/spinner'; | ||
| import { css, getModifier } from '@patternfly/react-styles'; | ||
| import { Omit } from '../../../helpers/typeUtils'; | ||
|
|
||
| export enum spinnerSize { | ||
| sm = 'sm', | ||
| md = 'md', | ||
| lg = 'lg', | ||
| xl = 'xl' | ||
| } | ||
|
|
||
| export interface SpinnerProps | ||
| extends Omit<React.HTMLProps<HTMLSpanElement>, 'size'> { | ||
| /** Additional classes added to the Spinner. */ | ||
| className?: string; | ||
| /** Size variant of progress. */ | ||
| size?: 'sm' | 'md' | 'lg' | 'xl'; | ||
| /** Aria value text */ | ||
| 'aria-valuetext'?: string; | ||
| } | ||
|
|
||
| export const Spinner: React.FunctionComponent<SpinnerProps> = ({ | ||
| className = '', | ||
| size = 'xl', | ||
| 'aria-valuetext': ariaValueText = 'Loading...', | ||
| ...props | ||
| }) => ( | ||
| <span | ||
| className={css(styles.spinner, getModifier(styles, size))} | ||
| role="progressbar" | ||
| aria-valuetext={ariaValueText} | ||
| {...props} | ||
| > | ||
| <span className={css(styles.spinnerClipper)} /> | ||
| <span className={css(styles.spinnerLeadBall)} /> | ||
| <span className={css(styles.spinnerTailBall)} /> | ||
| </span> | ||
| ); |
91 changes: 91 additions & 0 deletions
91
...nfly-4/react-core/src/experimental/components/Spinner/__snapshots__/Spinner.test.tsx.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`extra large spinner 1`] = ` | ||
| <span | ||
| aria-valuetext="Loading..." | ||
| className="pf-c-spinner pf-m-xl" | ||
| role="progressbar" | ||
| > | ||
| <span | ||
| className="pf-c-spinner__clipper" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__lead-ball" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__tail-ball" | ||
| /> | ||
| </span> | ||
| `; | ||
|
|
||
| exports[`large spinner 1`] = ` | ||
| <span | ||
| aria-valuetext="Loading..." | ||
| className="pf-c-spinner pf-m-xl" | ||
| role="progressbar" | ||
| > | ||
| <span | ||
| className="pf-c-spinner__clipper" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__lead-ball" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__tail-ball" | ||
| /> | ||
| </span> | ||
| `; | ||
|
|
||
| exports[`medium spinner 1`] = ` | ||
| <span | ||
| aria-valuetext="Loading..." | ||
| className="pf-c-spinner pf-m-xl" | ||
| role="progressbar" | ||
| > | ||
| <span | ||
| className="pf-c-spinner__clipper" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__lead-ball" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__tail-ball" | ||
| /> | ||
| </span> | ||
| `; | ||
|
|
||
| exports[`simple spinner 1`] = ` | ||
| <span | ||
| aria-valuetext="Loading..." | ||
| className="pf-c-spinner pf-m-xl" | ||
| role="progressbar" | ||
| > | ||
| <span | ||
| className="pf-c-spinner__clipper" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__lead-ball" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__tail-ball" | ||
| /> | ||
| </span> | ||
| `; | ||
|
|
||
| exports[`small spinner 1`] = ` | ||
| <span | ||
| aria-valuetext="Loading..." | ||
| className="pf-c-spinner pf-m-xl" | ||
| role="progressbar" | ||
| > | ||
| <span | ||
| className="pf-c-spinner__clipper" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__lead-ball" | ||
| /> | ||
| <span | ||
| className="pf-c-spinner__tail-ball" | ||
| /> | ||
| </span> | ||
| `; |
1 change: 1 addition & 0 deletions
1
packages/patternfly-4/react-core/src/experimental/components/Spinner/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from './Spinner'; |
1 change: 1 addition & 0 deletions
1
packages/patternfly-4/react-core/src/experimental/components/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| export * from './Button'; | ||
| export * from './Badge'; | ||
| export * from './Drawer'; | ||
| export * from './Spinner'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/patternfly-4/react-integration/cypress/integration/spinner.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| describe('Spinner Demo Test', () => { | ||
| it('Navigate to demo section', () => { | ||
| cy.visit('http://localhost:3000/'); | ||
| cy.get('#spinner-demo-nav-item-link').click(); | ||
| cy.url().should('eq', 'http://localhost:3000/spinner-demo-nav-link'); | ||
| }); | ||
| it('Verify small spinner', () => { | ||
| cy.get('.pf-c-spinner.pf-m-sm').should('exist'); | ||
| }); | ||
| it('Verify medium spinner', () => { | ||
| cy.get('.pf-c-spinner.pf-m-md').should('exist'); | ||
| }); | ||
| it('Verify large spinner', () => { | ||
| cy.get('.pf-c-spinner.pf-m-lg').should('exist'); | ||
| }); | ||
|
|
||
| it('Verify extra large spinner', () => { | ||
| cy.get('.pf-c-spinner.pf-m-xl').should('exist'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
...tternfly-4/react-integration/demo-app-ts/src/components/demos/SpinnerDemo/SpinnerDemo.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import React from 'react'; | ||
| import { Spinner, SpinnerProps } from '@patternfly/react-core/dist/esm/experimental'; | ||
|
|
||
| export class SpinnerDemo extends React.Component<SpinnerProps> { | ||
|
|
||
| componentDidMount() { | ||
| window.scrollTo(0, 0); | ||
| } | ||
|
|
||
| render() { | ||
| return ( | ||
| <React.Fragment> | ||
| <Spinner/> | ||
| <span> | ||
| <div>Size variations</div> | ||
| <Spinner size="sm"/> | ||
| <Spinner size="md"/> | ||
| <Spinner size="lg"/> | ||
| <Spinner size="xl"/> | ||
| </span> | ||
| </React.Fragment> | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityFor this to show up properly on -org, we are using a new stage: 'early' in the frontmatter. I'll address this in a follow-up PR.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.