Charts: Add props to ChartLabel - #3028
Merged
tlabaj merged 1 commit intoOct 8, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3028.surge.sh |
Sorry, something went wrong.
dlabrecq
force-pushed
the
3072-chart-label-props
branch
from
ace3b4e to
1de92ff
Compare
October 1, 2019 19:58
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #3028 +/- ##
==========================================
- Coverage 68.97% 68.93% -0.05%
==========================================
Files 857 857
Lines 23445 23437 -8
Branches 1847 1835 -12
==========================================
- Hits 16171 16156 -15
- Misses 6357 6365 +8
+ Partials 917 916 -1
Continue to review full report at Codecov.
|
Sorry, something went wrong.
dlabrecq
force-pushed
the
3072-chart-label-props
branch
from
1de92ff to
5df4208
Compare
October 2, 2019 20:29
redallen
approved these changes
Oct 3, 2019
tlabaj
approved these changes
Oct 8, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing textAnchor, transform, & verticalAnchor props to ChartLabel.
Fixes #3027