FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Charts: Add props to ChartLabel by dlabrecq · Pull Request #3028 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Charts: Add props to ChartLabel #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
Oct 8, 2019
Conversation 3 Commits 1 Checks 0 Files changed
Merged

Charts: Add props to ChartLabel #3028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .tsx  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
19 changes: 10 additions & 9 deletions packages/patternfly-4/react-charts/src/components/ChartLabel/ChartLabel.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
import * as React from 'react';
import hoistNonReactStatics from 'hoist-non-react-statics';
import { defaults } from 'lodash';
import { StringOrNumberOrCallback, VictoryLabel, VictoryLabelProps } from 'victory';
import {
StringOrNumberOrCallback,
TextAnchorType,
VerticalAnchorType,
VictoryLabel,
VictoryLabelProps
} from 'victory';
import { ChartCommonStyles } from '../ChartTheme';

export enum ChartLabelDirection {
Expand All @@ -16,8 +22,6 @@ export enum ChartLabelPlacement {
vertical = 'vertical'
}

type TextAnchorType = 'start' | 'middle' | 'end' | 'inherit';

/**
* See https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/victory/index.d.ts
*/
Expand Down Expand Up @@ -135,19 +139,16 @@ export interface ChartLabelProps extends VictoryLabelProps {
/**
* The textAnchor prop defines how the text is horizontally positioned relative to the given `x` and `y` coordinates.
*/
// Todo: function not working as type
// textAnchor?: TextAnchorType | { (): TextAnchorType };
textAnchor?: TextAnchorType | (() => TextAnchorType);
/**
* The transform prop applies a transform to the rendered `<text>` element.
* In addition to being a string, it can be an object containing transform definitions for easier authoring.
*/
// Todo: function not working as type
// transform?: string | {} | { (): string | {} };
transform?: string | {} | (() => string);
/**
* The verticalAnchor prop defines how the text is vertically positioned relative to the given `x` and `y` coordinates
*/
// Todo: function not working as type
// verticalAnchor?: VerticalAnchorType | { (): VerticalAnchorType };
verticalAnchor?: VerticalAnchorType | (() => VerticalAnchorType);
/**
* The x prop defines the x coordinate to use as a basis for horizontal positioning.
*/
Expand Down
Back | FazBrowse Home | New Git URL