FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Coverage for Cypress tests by jenny-s51 · Pull Request #3295 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Coverage for Cypress tests - #3295

Merged
evwilkin merged 5 commits into
patternfly:masterfrom
jenny-s51:iss3199
Jan 23, 2020
ConversationCommits (5)ChecksFiles changed
Merged

Coverage for Cypress tests#3295
evwilkin merged 5 commits into
patternfly:masterfrom
jenny-s51:iss3199

Conversation

jenny-s51 commented Nov 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR for #3199

jenny-s51 changed the title WIP[coverage for cypress tests]: installed necessary packages WIP[coverage for cypress tests] Nov 15, 2019

patternfly-build commented Nov 15, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3295.surge.sh

codecov-io commented Nov 18, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3295 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3295   +/-   ##
=======================================
  Coverage   67.11%   67.11%           
=======================================
  Files         903      903           
  Lines       25502    25502           
  Branches     2262     2262           
=======================================
  Hits        17115    17115           
  Misses       7346     7346           
  Partials     1041     1041
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327402f...2934862. Read the comment docs.

jenny-s51 force-pushed the iss3199 branch 2 times, most recently from 3657660 to c6a240c Compare January 7, 2020 18:50
jenny-s51 mentioned this pull request Jan 13, 2020
Closed
jenny-s51 requested a review from redallen January 14, 2020 19:19
redallen reviewed Jan 14, 2020
View reviewed changes
Comment thread .circleci/config.yml Outdated
Comment thread .circleci/config.yml Outdated
Comment thread .circleci/config.yml
Comment thread .circleci/config.yml Outdated
Comment thread yarn.lock Outdated
Comment thread .circleci/config.yml
jenny-s51 force-pushed the iss3199 branch 2 times, most recently from e56513c to 2c3b09f Compare January 15, 2020 18:03
redallen reviewed Jan 15, 2020
View reviewed changes
Comment thread .circleci/config.yml
Comment thread .circleci/config.yml
jenny-s51 changed the title WIP[coverage for cypress tests] Coverage for Cypress tests Jan 15, 2020
redallen approved these changes Jan 23, 2020
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @jenny-s51 and @dgutride !

tlabaj reviewed Jan 23, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin approved these changes Jan 23, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin merged commit 462169e into patternfly:master Jan 23, 2020

evwilkin commented Jan 23, 2020

Copy link
Copy Markdown
Member

Resolves #3199

redallen mentioned this pull request Jan 24, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin approved these changes
+3 more reviewers
tlabaj tlabaj left review comments
dgutride dgutride approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL