FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ci): stop caching stale doc builds by redallen · Pull Request #3582 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(ci): stop caching stale doc builds - #3582

Merged
ddonahue007 merged 2 commits into
patternfly:masterfrom
redallen:fix/stale-pr-previews
Jan 24, 2020
ConversationCommits (2)ChecksFiles changed
Merged

fix(ci): stop caching stale doc builds#3582
ddonahue007 merged 2 commits into
patternfly:masterfrom
redallen:fix/stale-pr-previews

Conversation

redallen commented Jan 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Revert some of #3295 which aggressively cached our docs in order to show the Cypress coverage results. This PR stops uploading them to Surge for now.

Additional issues:

patternfly-build commented Jan 24, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3582.surge.sh

codecov-io commented Jan 24, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@82f1a46). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3582   +/-   ##
=========================================
  Coverage          ?   67.11%           
=========================================
  Files             ?      903           
  Lines             ?    25515           
  Branches          ?     2262           
=========================================
  Hits              ?    17125           
  Misses            ?     7349           
  Partials          ?     1041
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.22% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f1a46...ad377ce. Read the comment docs.

evwilkin approved these changes Jan 24, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jenny-s51 approved these changes Jan 24, 2020
View reviewed changes

jenny-s51 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice catch!

ddonahue007 approved these changes Jan 24, 2020
View reviewed changes

ddonahue007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ddonahue007 merged commit 4dadd69 into patternfly:master Jan 24, 2020
dlabrecq reviewed Jan 24, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin approved these changes
tlabaj Awaiting requested review from tlabaj
dgutride Awaiting requested review from dgutride
seanforyou23 Awaiting requested review from seanforyou23
+3 more reviewers
dlabrecq dlabrecq left review comments
jenny-s51 jenny-s51 approved these changes
ddonahue007 ddonahue007 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL