FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Select): Display pre-selected input by Venefilyn · Pull Request #3305 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Select): Display pre-selected input - #3305

Merged
tlabaj merged 2 commits into
patternfly:masterfrom
Venefilyn:fix/pre-select-typeahead
Nov 20, 2019
ConversationCommits (2)ChecksFiles changed
Merged

fix(Select): Display pre-selected input#3305
tlabaj merged 2 commits into
patternfly:masterfrom
Venefilyn:fix/pre-select-typeahead

Conversation

Venefilyn commented Nov 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Closes #3304

Defaults typeaheadInputValue to null and sets it accordingly when clearing selections as well

Additional issues:

Venefilyn force-pushed the fix/pre-select-typeahead branch from 9b49bcf to e0d4e85 Compare November 14, 2019 12:30

patternfly-build commented Nov 14, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3305.surge.sh

tlabaj requested a review from kmcfaul November 18, 2019 15:24
tlabaj requested a review from jessiehuff November 18, 2019 15:25
Venefilyn force-pushed the fix/pre-select-typeahead branch from e0d4e85 to d3591a7 Compare November 19, 2019 09:44

codecov-io commented Nov 19, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@2415a94). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3305   +/-   ##
=========================================
  Coverage          ?   67.45%           
=========================================
  Files             ?      892           
  Lines             ?    24874           
  Branches          ?     2141           
=========================================
  Hits              ?    16778           
  Misses            ?     7092           
  Partials          ?     1004
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.79% <100%> (?)
Impacted Files Coverage Δ
...nfly-4/react-core/src/components/Select/Select.tsx 63.87% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2415a94...7836046. Read the comment docs.

dlabaj previously approved these changes Nov 19, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

kmcfaul previously approved these changes Nov 19, 2019
View reviewed changes
tlabaj reviewed Nov 19, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like you need to update your jest test

Venefilyn dismissed stale reviews from kmcfaul and dlabaj via 7836046 November 20, 2019 12:39

Venefilyn commented Nov 20, 2019

Copy link
Copy Markdown
Contributor Author

Thanks, updated the tests

tlabaj approved these changes Nov 20, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit f04fe92 into patternfly:master Nov 20, 2019

patternfly-build commented Nov 20, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.29
  • @patternfly/react-core@3.122.1
  • @patternfly/react-docs@4.16.35
  • @patternfly/react-inline-edit-extension@2.13.2
  • demo-app-ts@3.11.1
  • @patternfly/react-table@2.24.34
  • @patternfly/react-topology@2.11.20
  • @patternfly/react-virtualized-extension@1.3.33

Thanks for your contribution! 🎉

Venefilyn deleted the fix/pre-select-typeahead branch November 25, 2019 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
kmcfaul kmcfaul approved these changes
jessiehuff Awaiting requested review from jessiehuff
+1 more reviewer
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

kmcfaul

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Select Typeahead doesn't display pre-selected value

6 participants

Back | FazBrowse Home | New Git URL