FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Select): Display pre-selected input by Venefilyn · Pull Request #3305 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Select): Display pre-selected input #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 2 commits into from
Nov 20, 2019
Conversation 7 Commits 2 Checks 0 Files changed
Merged

fix(Select): Display pre-selected input #3305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3591a7
fix(Select): Display pre-selected input
Venefilyn Nov 14, 2019
7836046
test(Select): Update snapshots
Venefilyn Nov 20, 2019
File filter

Filter by extension

Filter by extension .snap  (1) .tsx  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
    • Select.tsx
      • Select.test.tsx.snap
8 changes: 4 additions & 4 deletions packages/patternfly-4/react-core/src/components/Select/Select.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export interface SelectProps

export interface SelectState {
openedOnEnter: boolean;
typeaheadInputValue: string;
typeaheadInputValue: string|null;
typeaheadActiveChild?: HTMLElement;
typeaheadFilteredChildren: React.ReactNode[];
typeaheadCurrIndex: number;
Expand Down Expand Up @@ -122,9 +122,9 @@ class Select extends React.Component<SelectProps & InjectedOuiaProps, SelectStat
onFilter: null
} as Partial<SelectProps & InjectedOuiaProps>;

state = {
state: SelectState = {
openedOnEnter: false,
typeaheadInputValue: '',
typeaheadInputValue: null,
typeaheadActiveChild: null as HTMLElement,
typeaheadFilteredChildren: React.Children.toArray(this.props.children),
typeaheadCurrIndex: -1,
Expand Down Expand Up @@ -215,7 +215,7 @@ class Select extends React.Component<SelectProps & InjectedOuiaProps, SelectStat
clearSelection = (e: React.MouseEvent) => {
e.stopPropagation();
this.setState({
typeaheadInputValue: '',
typeaheadInputValue: null,
typeaheadActiveChild: null,
typeaheadFilteredChildren: React.Children.toArray(this.props.children),
typeaheadCurrIndex: -1
Expand Down
4 changes: 2 additions & 2 deletions packages/patternfly-4/react-core/src/components/Select/__snapshots__/Select.test.tsx.snap
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -8997,7 +8997,7 @@ exports[`typeahead select renders selected successfully 1`] = `
id="select-typeahead"
placeholder=""
type="text"
value=""
value="Mr"
/>
</div>
<button
Expand Down Expand Up @@ -9140,7 +9140,7 @@ exports[`typeahead select renders selected successfully 1`] = `
onFocus={[Function]}
placeholder=""
type="text"
value=""
value="Mr"
/>
</div>
<button
Expand Down
Back | FazBrowse Home | New Git URL