FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(topology): Set topology container to take full height of the view by jeff-phillips-18 · Pull Request #3314 · patternfly/patternfly-react · GitHub

fix(topology): Set topology container to take full height of the view - #3314

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
jeff-phillips-18:topology-package
Nov 18, 2019
Merged

fix(topology): Set topology container to take full height of the view#3314
tlabaj merged 1 commit into
patternfly:masterfrom
jeff-phillips-18:topology-package

Conversation

Copy link
Copy Markdown
Member

Closes #3312

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3314.surge.sh

codecov-io commented Nov 18, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3314 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3314      +/-   ##
==========================================
+ Coverage   67.44%   67.44%   +<.01%     
==========================================
  Files         892      892              
  Lines       24873    24874       +1     
  Branches     2141     2141              
==========================================
+ Hits        16775    16776       +1     
  Misses       7093     7093              
  Partials     1005     1005
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.78% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...yles/src/css/components/Topology/topology-view.css 100% <ø> (ø) ⬆️
...ology/src/components/TopologyView/TopologyView.tsx 94.73% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8469e10...79b014f. Read the comment docs.

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 2b15cc0 into patternfly:master Nov 18, 2019
jeff-phillips-18 deleted the topology-package branch November 11, 2021 14:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Topology view does not take full height at small resolutions in Safari or on iOS

5 participants


Back | FazBrowse Home | New Git URL