FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(topology): Set topology container to take full height of the view by jeff-phillips-18 · Pull Request #3314 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(topology): Set topology container to take full height of the view #3314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
Nov 18, 2019
Conversation 3 Commits 1 Checks 0 Files changed
Merged

fix(topology): Set topology container to take full height of the view #3314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .css  (1) .snap  (1) .tsx  (1) All 3 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
      • topology-view.css
      • TopologyView.tsx
6 changes: 5 additions & 1 deletion packages/patternfly-4/react-styles/src/css/components/Topology/topology-view.css
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,8 @@
align-items: center;
width: 100%;
height: 100%;
}
}

.pf-topology-container {
flex: 1;
}
3 changes: 2 additions & 1 deletion packages/patternfly-4/react-topology/src/components/TopologyView/TopologyView.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ export const TopologyView: React.FunctionComponent<TopologyViewProps> = ({
...props
}: TopologyViewProps) => {
const containerClasses =
`${sideBar ? 'pf-topology-container__with-sidebar' : ''}` +
'pf-topology-container' +
`${sideBar ? ' pf-topology-container__with-sidebar' : ''}` +
`${sideBarOpen ? ' pf-topology-container__with-sidebar--open' : ''}`;

return (
Expand Down
16 changes: 8 additions & 8 deletions ...fly-4/react-topology/src/components/TopologyView/__snapshots__/TopologyView.test.tsx.snap
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ exports[`TopologyView should display an empty topology correctly 1`] = `
id="simple-test-id"
>
<StackItem
className=""
className="pf-topology-container"
isFilled={true}
>
<div
className="pf-l-stack__item pf-m-fill"
className="pf-l-stack__item pf-m-fill pf-topology-container"
>
<div
className="pf-topology-content"
Expand Down Expand Up @@ -81,11 +81,11 @@ exports[`TopologyView should display topology correctly 1`] = `
</div>
</StackItem>
<StackItem
className=""
className="pf-topology-container"
isFilled={true}
>
<div
className="pf-l-stack__item pf-m-fill"
className="pf-l-stack__item pf-m-fill pf-topology-container"
>
<div
className="pf-topology-content"
Expand Down Expand Up @@ -165,11 +165,11 @@ exports[`TopologyView should display topology sidebar correctly 1`] = `
</div>
</StackItem>
<StackItem
className="pf-topology-container__with-sidebar"
className="pf-topology-container pf-topology-container__with-sidebar"
isFilled={true}
>
<div
className="pf-l-stack__item pf-m-fill pf-topology-container__with-sidebar"
className="pf-l-stack__item pf-m-fill pf-topology-container pf-topology-container__with-sidebar"
>
<div
className="pf-topology-content"
Expand Down Expand Up @@ -252,11 +252,11 @@ exports[`TopologyView should display topology w/ open sidebar correctly 1`] = `
</div>
</StackItem>
<StackItem
className="pf-topology-container__with-sidebar pf-topology-container__with-sidebar--open"
className="pf-topology-container pf-topology-container__with-sidebar pf-topology-container__with-sidebar--open"
isFilled={true}
>
<div
className="pf-l-stack__item pf-m-fill pf-topology-container__with-sidebar pf-topology-container__with-sidebar--open"
className="pf-l-stack__item pf-m-fill pf-topology-container pf-topology-container__with-sidebar pf-topology-container__with-sidebar--open"
>
<div
className="pf-topology-content"
Expand Down
Back | FazBrowse Home | New Git URL