FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Pagination): fixed prev arrows are active with 0 rows by evwilkin · Pull Request #3384 · patternfly/patternfly-react · GitHub

fix(Pagination): fixed prev arrows are active with 0 rows - #3384

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
evwilkin:fix/pagination_3377
Dec 6, 2019
Merged

fix(Pagination): fixed prev arrows are active with 0 rows#3384
tlabaj merged 1 commit into
patternfly:masterfrom
evwilkin:fix/pagination_3377

Conversation

evwilkin commented Dec 6, 2019

Copy link
Copy Markdown
Member

What: Closes #3377

Additional issues:

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3384.surge.sh

codecov-io commented Dec 6, 2019
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3384 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3384   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files         897      897           
  Lines       25158    25158           
  Branches     2181     2181           
=======================================
  Hits        16980    16980           
  Misses       7162     7162           
  Partials     1016     1016
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.95% <100%> (ø) ⬆️
Impacted Files Coverage Δ
...eact-core/src/components/Pagination/Navigation.tsx 86.81% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e57d8...219ddd4. Read the comment docs.

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 901cb13 into patternfly:master Dec 6, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.49
  • @patternfly/react-core@3.126.5
  • @patternfly/react-docs@4.16.58
  • @patternfly/react-inline-edit-extension@2.14.8
  • demo-app-ts@3.14.5
  • @patternfly/react-table@2.24.52
  • @patternfly/react-topology@2.11.37
  • @patternfly/react-virtualized-extension@1.3.50

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

previous page should not be active on 0 items Pagination objects

5 participants


Back | FazBrowse Home | New Git URL