FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Pagination): fixed prev arrows are active with 0 rows by evwilkin · Pull Request #3384 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Pagination): fixed prev arrows are active with 0 rows #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
Dec 6, 2019
Conversation 4 Commits 1 Checks 0 Files changed
Merged

fix(Pagination): fixed prev arrows are active with 0 rows #3384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .snap  (1) .tsx  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
    • Navigation.tsx
4 changes: 2 additions & 2 deletions packages/patternfly-4/react-core/src/components/Pagination/Navigation.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ export class Navigation extends React.Component<NavigationProps, NavigationState
{!isCompact && (
<Button
variant={ButtonVariant.plain}
isDisabled={isDisabled || page === firstPage}
isDisabled={isDisabled || page === firstPage || page === 0}
aria-label={toFirstPage}
data-action="first"
onClick={event => {
Expand All @@ -168,7 +168,7 @@ export class Navigation extends React.Component<NavigationProps, NavigationState
)}
<Button
variant={ButtonVariant.plain}
isDisabled={isDisabled || page === firstPage}
isDisabled={isDisabled || page === firstPage || page === 0}
data-action="previous"
onClick={event => {
const newPage = (page as number) - 1 >= 1 ? (page as number) - 1 : 1;
Expand Down
32 changes: 16 additions & 16 deletions .../patternfly-4/react-core/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -6264,7 +6264,7 @@ exports[`component render no items 1`] = `
<Component
aria-label="Go to first page"
data-action="first"
isDisabled={false}
isDisabled={true}
onClick={[Function]}
variant="plain"
>
Expand All @@ -6280,7 +6280,7 @@ exports[`component render no items 1`] = `
title={null}
/>,
"data-action": "first",
"isDisabled": false,
"isDisabled": true,
"onClick": [Function],
"variant": "plain",
}
Expand All @@ -6295,7 +6295,7 @@ exports[`component render no items 1`] = `
<Button
aria-label="Go to first page"
data-action="first"
isDisabled={false}
isDisabled={true}
onClick={[Function]}
ouiaContext={
Object {
Expand All @@ -6310,7 +6310,7 @@ exports[`component render no items 1`] = `
aria-label="Go to first page"
className="pf-c-button pf-m-plain"
data-action="first"
disabled={false}
disabled={true}
onClick={[Function]}
tabIndex={null}
type="button"
Expand Down Expand Up @@ -6348,7 +6348,7 @@ exports[`component render no items 1`] = `
<Component
aria-label="Go to previous page"
data-action="previous"
isDisabled={false}
isDisabled={true}
onClick={[Function]}
variant="plain"
>
Expand All @@ -6364,7 +6364,7 @@ exports[`component render no items 1`] = `
title={null}
/>,
"data-action": "previous",
"isDisabled": false,
"isDisabled": true,
"onClick": [Function],
"variant": "plain",
}
Expand All @@ -6379,7 +6379,7 @@ exports[`component render no items 1`] = `
<Button
aria-label="Go to previous page"
data-action="previous"
isDisabled={false}
isDisabled={true}
onClick={[Function]}
ouiaContext={
Object {
Expand All @@ -6394,7 +6394,7 @@ exports[`component render no items 1`] = `
aria-label="Go to previous page"
className="pf-c-button pf-m-plain"
data-action="previous"
disabled={false}
disabled={true}
onClick={[Function]}
tabIndex={null}
type="button"
Expand Down Expand Up @@ -13320,7 +13320,7 @@ exports[`component render zero results 1`] = `
<Component
aria-label="Go to first page"
data-action="first"
isDisabled={false}
isDisabled={true}
onClick={[Function]}
variant="plain"
>
Expand All @@ -13336,7 +13336,7 @@ exports[`component render zero results 1`] = `
title={null}
/>,
"data-action": "first",
"isDisabled": false,
"isDisabled": true,
"onClick": [Function],
"variant": "plain",
}
Expand All @@ -13351,7 +13351,7 @@ exports[`component render zero results 1`] = `
<Button
aria-label="Go to first page"
data-action="first"
isDisabled={false}
isDisabled={true}
onClick={[Function]}
ouiaContext={
Object {
Expand All @@ -13366,7 +13366,7 @@ exports[`component render zero results 1`] = `
aria-label="Go to first page"
className="pf-c-button pf-m-plain"
data-action="first"
disabled={false}
disabled={true}
onClick={[Function]}
tabIndex={null}
type="button"
Expand Down Expand Up @@ -13404,7 +13404,7 @@ exports[`component render zero results 1`] = `
<Component
aria-label="Go to previous page"
data-action="previous"
isDisabled={false}
isDisabled={true}
onClick={[Function]}
variant="plain"
>
Expand All @@ -13420,7 +13420,7 @@ exports[`component render zero results 1`] = `
title={null}
/>,
"data-action": "previous",
"isDisabled": false,
"isDisabled": true,
"onClick": [Function],
"variant": "plain",
}
Expand All @@ -13435,7 +13435,7 @@ exports[`component render zero results 1`] = `
<Button
aria-label="Go to previous page"
data-action="previous"
isDisabled={false}
isDisabled={true}
onClick={[Function]}
ouiaContext={
Object {
Expand All @@ -13450,7 +13450,7 @@ exports[`component render zero results 1`] = `
aria-label="Go to previous page"
className="pf-c-button pf-m-plain"
data-action="previous"
disabled={false}
disabled={true}
onClick={[Function]}
tabIndex={null}
type="button"
Expand Down
Back | FazBrowse Home | New Git URL