FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Table): Fix the ActionColumn to allow a link in the actions menu by tlabaj · Pull Request #3402 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Table): Fix the ActionColumn to allow a link in the actions menu - #3402

Merged
jschuler merged 2 commits into
patternfly:masterfrom
tlabaj:issue3392
Dec 13, 2019
ConversationCommits (2)ChecksFiles changed
Merged

fix(Table): Fix the ActionColumn to allow a link in the actions menu#3402
jschuler merged 2 commits into
patternfly:masterfrom
tlabaj:issue3392

Conversation

tlabaj commented Dec 12, 2019 •
edited by dlabaj
Loading

Copy link
Copy Markdown
Contributor

Closes #3392

patternfly-build commented Dec 12, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3402.surge.sh

codecov-io commented Dec 12, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3402 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3402      +/-   ##
==========================================
- Coverage   67.46%   67.46%   -0.01%     
==========================================
  Files         897      897              
  Lines       25164    25165       +1     
  Branches     2183     2184       +1     
==========================================
  Hits        16978    16978              
- Misses       7168     7169       +1     
  Partials     1018     1018
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.28% <ø> (ø) ⬆️
#patternfly4 64.89% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...react-table/src/components/Table/ActionsColumn.tsx 76% <0%> (-3.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9909f88...0c728ba. Read the comment docs.

dlabaj previously approved these changes Dec 12, 2019
View reviewed changes
jschuler reviewed Dec 13, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-table/src/components/Table/ActionsColumn.tsx Outdated
// tslint:disable-next-line:no-unused-expression
onClick && onClick(event as React.MouseEvent, extraData && extraData.rowIndex, rowData, extraData);
// Only prevent default if onClick is provided. This allows href support.
if (onclick) {

jschuler Dec 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should the c be capitalized?

Suggested change
if (onclick) {
if (onClick) {

seanforyou23 previously approved these changes Dec 13, 2019
View reviewed changes

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

tlabaj dismissed stale reviews from seanforyou23 and dlabaj via 0c728ba December 13, 2019 21:45
seanforyou23 approved these changes Dec 13, 2019
View reviewed changes

seanforyou23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

jschuler merged commit e609cdd into patternfly:master Dec 13, 2019

patternfly-build commented Dec 13, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-docs@4.16.64
  • @patternfly/react-inline-edit-extension@2.14.13
  • @patternfly/react-table@2.24.57

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj left review comments
+2 more reviewers
jschuler jschuler approved these changes
seanforyou23 seanforyou23 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Table ActionsColumn: Action can't be a link due to preventDefault

6 participants

Back | FazBrowse Home | New Git URL