FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Table): Fix the ActionColumn to allow a link in the actions menu by tlabaj · Pull Request #3402 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Table): Fix the ActionColumn to allow a link in the actions menu #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jschuler merged 2 commits into from
Dec 13, 2019
Conversation 6 Commits 2 Checks 0 Files changed
Merged

fix(Table): Fix the ActionColumn to allow a link in the actions menu #3402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c0973e
fix(Table): Fix the ActionColum to allow a link in the actions menu
Dec 12, 2019
0c728ba
fix typo
Dec 13, 2019
File filter

Filter by extension

Filter by extension .md  (1) .tsx  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
    • ActionsColumn.tsx
    • Table.md
9 changes: 6 additions & 3 deletions packages/patternfly-4/react-table/src/components/Table/ActionsColumn.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,12 @@ export class ActionsColumn extends React.Component<ActionsColumnProps, ActionsCo
| undefined
): void => {
const { rowData, extraData } = this.props;
event.preventDefault();
// tslint:disable-next-line:no-unused-expression
onClick && onClick(event as React.MouseEvent, extraData && extraData.rowIndex, rowData, extraData);
// Only prevent default if onClick is provided. This allows href support.
if (onClick) {
event.preventDefault();
// tslint:disable-next-line:no-unused-expression
onClick(event as React.MouseEvent, extraData && extraData.rowIndex, rowData, extraData);
}
this.setState(prevState => ({
isOpen: !prevState.isOpen
}));
Expand Down
3 changes: 1 addition & 2 deletions packages/patternfly-4/react-table/src/components/Table/Table.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,7 @@ class SimpleActionsTable extends React.Component {
onClick: (event, rowId, rowData, extra) => console.log('clicked on Some action, on row: ', rowId)
},
{
title: <div>Another action</div>,
onClick: (event, rowId, rowData, extra) => console.log('clicked on Another action, on row: ', rowId)
title: <a href="https://www.patternfly.org">Link action</a>
},
{
isSeparator: true
Expand Down
Back | FazBrowse Home | New Git URL