FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Page layout demo imports 3439 by ddonahue007 · Pull Request #3461 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Page layout demo imports 3439 - #3461

Merged
ddonahue007 merged 6 commits into
patternfly:masterfrom
ddonahue007:page-layout-demo-imports_3439
Jan 8, 2020
ConversationCommits (6)ChecksFiles changed
Merged

Page layout demo imports 3439#3461
ddonahue007 merged 6 commits into
patternfly:masterfrom
ddonahue007:page-layout-demo-imports_3439

Conversation

ddonahue007 commented Jan 7, 2020

Copy link
Copy Markdown
Member

dlabrecq approved these changes Jan 7, 2020
View reviewed changes

dlabrecq left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Travis build has an error

dlabrecq previously requested changes Jan 7, 2020
View reviewed changes

dlabrecq left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can't resolve '../../../../../react-core/src/demos/PageLayout/examples/imgBrand.svg' in '/home/circleci/project/packages/patternfly-4/react-docs/.cache/caches/gatsby-plugin-mdx/mdx-scopes-dir'

dlabrecq dismissed their stale review January 7, 2020 20:09

Travis build fails

ddonahue007 requested a review from evwilkin January 7, 2020 21:11

patternfly-build commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3461.surge.sh

codecov-io commented Jan 8, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3461 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3461   +/-   ##
======================================
  Coverage    67.1%   67.1%           
======================================
  Files         903     903           
  Lines       25471   25471           
  Branches     2251    2251           
======================================
  Hits        17092   17092           
  Misses       7342    7342           
  Partials     1037    1037
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 69.29% <ø> (ø) ⬆️
#patternfly4 64.21% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d1221...65f572e. Read the comment docs.

dlabrecq approved these changes Jan 8, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

evwilkin approved these changes Jan 8, 2020
View reviewed changes

evwilkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

ddonahue007 merged commit 2ff3592 into patternfly:master Jan 8, 2020

patternfly-build commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.1.63
  • @patternfly/react-core@3.129.6
  • @patternfly/react-docs@4.16.76
  • @patternfly/react-inline-edit-extension@2.14.23
  • demo-app-ts@3.16.6
  • @patternfly/react-table@2.24.67
  • @patternfly/react-topology@2.11.51
  • @patternfly/react-virtualized-extension@1.3.64

Thanks for your contribution! 🎉

ddonahue007 deleted the page-layout-demo-imports_3439 branch January 8, 2020 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

evwilkin evwilkin approved these changes
redallen Awaiting requested review from redallen
+1 more reviewer
dlabrecq dlabrecq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL