FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Page layout demo imports 3439 by ddonahue007 · Pull Request #3461 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Page layout demo imports 3439 #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddonahue007 merged 6 commits into from
Jan 8, 2020
Conversation 7 Commits 6 Checks 0 Files changed
Merged

Page layout demo imports 3439 #3461

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80375d8
fix(demos): import statements and image suffix
ddonahue007 Jan 6, 2020
2b3a9e0
fix(demos):revert image suffix back to .svg
ddonahue007 Jan 7, 2020
19d0805
fix(demos):revert image suffix back to .svg
ddonahue007 Jan 7, 2020
0236c1e
fix(demos): moved import to follow sort order
ddonahue007 Jan 7, 2020
e5bd58e
fix(demos): small change to trigger build
ddonahue007 Jan 7, 2020
65f572e
fix(demos): added missing svg files
ddonahue007 Jan 8, 2020
File filter

Filter by extension

Filter by extension .md  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
19 changes: 16 additions & 3 deletions packages/patternfly-4/react-core/src/demos/PageLayout/examples/PageLayout.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import imgAvatar from './imgAvatar.svg';
- All but the last example set the `isManagedSidebar` prop on the Page component to have the sidebar automatically close for smaller screen widths. You can also manually control this behavior by not adding the `isManagedSidebar` prop and instead:

1. Add an onNavToggle callback to PageHeader
1. Pass in a boolean into the isNavOpen prop to PageSidebar
1. Pass a boolean into the isNavOpen prop to PageSidebar

The last example demonstrates this.

Expand All @@ -58,16 +58,22 @@ import React from 'react';
import {
Avatar,
Brand,
Breadcrumb,
BreadcrumbItem,
Button,
ButtonVariant,
Dropdown,
Card,
CardBody,
DropdownToggle,
DropdownItem,
DropdownSeparator,
Gallery,
GalleryItem,
KebabToggle,
Nav,
NavGroup,
NavItem,
NavList,
Page,
PageHeader,
PageSection,
Expand Down Expand Up @@ -274,16 +280,23 @@ import React from 'react';
import {
Avatar,
Brand,
Breadcrumb,
BreadcrumbItem,
Button,
ButtonVariant,
Card,
CardBody,
Dropdown,
DropdownToggle,
DropdownItem,
DropdownSeparator,
Gallery,
GalleryItem,
KebabToggle,
Nav,
NavGroup,
NavExpandable,
NavItem,
NavList,
Page,
PageHeader,
PageSection,
Expand Down
Back | FazBrowse Home | New Git URL