@redallen everything looks good except with build of react-topology/TopologyControlBar and react-topology/TopologySideBar components.

Typescript props checking is getting crazy and throwing this error:

error TS2741: Property 'css' is missing in type '{ children: (string | number | boolean | {} | ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)>) | (new (props: any) => Component<any, any, any>)> | ReactNodeArray | ReactPortal | Element)[]; ... 5 more ...; variant: "tertiary"; }' but required in type 'Pick<ButtonProps & InjectedOuiaProps, "className" | "children" | "accept" | "acceptCharset" | "action" | "allowFullScreen" | "allowTransparency" | "alt" | "as" | "async" | ... 360 more ... | "icon"> 

Adding the css prop to the Button component fixes that, but that is obviously not the solution to the issue. Apparently this is caused by emotion and how it applies the styles to components.

Both components have css imports in the file but removing them has no effect.

I was looking for some solutions online but without luck. They mostly recommend updating emotion ^10.x, but that is a very invasive change.

Have you ever encounter this issue?

PatternFly-React preview: https://patternfly-react-pr-3525.surge.sh

Codecov Report

Merging #3525 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3525      +/-   ##
==========================================
+ Coverage   67.11%   67.11%   +<.01%     
==========================================
  Files         903      903              
  Lines       25502    25515      +13     
  Branches     2262     2262              
==========================================
+ Hits        17115    17125      +10     
- Misses       7346     7349       +3     
  Partials     1041     1041

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327402f...b62e743. Read the comment docs.

@redallen @evwilkin I've reverted the changes in components that caused the TS issues. This only affects the topology package. I went through the dist files and there are no imports from react-core with the exception of the topology component.