FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(pf4): Use absolute import paths for react core in pf4 packages. by Hyperkid123 · Pull Request #3525 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(pf4): Use absolute import paths for react core in pf4 packages. #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evwilkin merged 2 commits into from
Jan 24, 2020
Conversation 5 Commits 2 Checks 0 Files changed
Merged

feat(pf4): Use absolute import paths for react core in pf4 packages. #3525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
144038e
feat(pf4): Use absolute import paths for react core in pf4 packages.
Hyperkid123 Jan 17, 2020
b62e743
Reved absolute import from TopologySidebar and TopologyControlBar.
Hyperkid123 Jan 23, 2020
File filter

Filter by extension

Filter by extension .js  (11) .ts  (3) .tsx  (10) All 3 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
        • CatalogTile.tsx
        • PropertyItem.tsx
        • SampleForm.js
      • icons.js
      • index.js
        • CancelButton.js
        • ConfirmButton.js
        • InlineEdit.api.test.js
        • editableTableBody.d.ts
        • TableTextInput.d.ts
        • TableTextInput.js
      • State.ts
      • ActionsColumn.tsx
      • CollapseColumn.tsx
      • RowWrapper.tsx
      • Table.tsx
        • compoundExpand.tsx
      • TopologyView.tsx
        • ItemDetails.js
        • ProjectToolbar.js
7 changes: 6 additions & 1 deletion ...ages/patternfly-4/react-catalog-view-extension/src/components/CatalogTile/CatalogTile.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import * as React from 'react';
import { Card, CardActions, CardHead, CardHeader, CardBody, CardFooter } from '@patternfly/react-core';
import { Card } from '@patternfly/react-core/dist/js/components/Card/Card';
import { CardActions } from '@patternfly/react-core/dist/js/components/Card/CardActions';
import { CardHead } from '@patternfly/react-core/dist/js/components/Card/CardHead';
import { CardHeader } from '@patternfly/react-core/dist/js/components/Card/CardHeader';
import { CardBody } from '@patternfly/react-core/dist/js/components/Card/CardBody';
import { CardFooter } from '@patternfly/react-core/dist/js/components/Card/CardFooter';
import classNames from 'classnames';

import { Omit } from '../../helpers/typeUtils';
Expand Down
2 changes: 1 addition & 1 deletion ...4/react-catalog-view-extension/src/components/FilterSidePanel/FilterSidePanelCategory.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import classNames from 'classnames';
import { Button } from '@patternfly/react-core';
import { Button } from '@patternfly/react-core/dist/js/components/Button';
import { default as formStyles } from '@patternfly/react-styles/css/components/Form/form';
import { css } from '@patternfly/react-styles';

Expand Down
2 changes: 1 addition & 1 deletion ...act-catalog-view-extension/src/components/FilterSidePanel/FilterSidePanelCategoryItem.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import classNames from 'classnames';
import { Checkbox } from '@patternfly/react-core';
import { Checkbox } from '@patternfly/react-core/dist/js/components/Checkbox/Checkbox';

import { getUniqueId } from '../../helpers/util';

Expand Down
2 changes: 1 addition & 1 deletion ...ernfly-4/react-catalog-view-extension/src/components/PropertiesSidePanel/PropertyItem.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import classNames from 'classnames';

import { Omit } from '../../helpers/typeUtils';
import { Text, TextVariants } from '@patternfly/react-core';
import { Text, TextVariants } from '@patternfly/react-core/dist/js/components/Text/Text';

export interface PropertyItemProps extends Omit<React.HTMLProps<HTMLDivElement>, 'label' | 'value'> {
/** Additional css classes for the Property Item */
Expand Down
4 changes: 3 additions & 1 deletion packages/patternfly-4/react-core/src/components/Wizard/examples/SampleForm.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import React from 'react';
import PropTypes from 'prop-types';
import { Form, FormGroup, TextInput } from '@patternfly/react-core';
import { Form } from '@patternfly/react-core/dist/js/components/Form/Form'
import { FormGroup } from '@patternfly/react-core/dist/js/components/Form/FormGroup'
import { TextInput } from '@patternfly/react-core/dist/js/components/TextInput/TextInput'

const propTypes = {
formValue: PropTypes.string,
Expand Down
4 changes: 3 additions & 1 deletion packages/patternfly-4/react-core/src/layouts/Toolbar/examples/SimpleToolbar.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import React from 'react';
import { Toolbar, ToolbarGroup, ToolbarItem } from '@patternfly/react-core';
import { Toolbar } from '@patternfly/react-core/dist/js/layouts/Toolbar/Toolbar'
import { ToolbarGroup } from '@patternfly/react-core/dist/js/layouts/Toolbar/ToolbarGroup'
import { ToolbarItem } from '@patternfly/react-core/dist/js/layouts/Toolbar/ToolbarItem'

class SimpleToolbar extends React.Component {
render() {
Expand Down
5 changes: 4 additions & 1 deletion packages/patternfly-4/react-core/src/layouts/Toolbar/examples/SimpleToolbarSection.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import React from 'react';
import { Toolbar, ToolbarGroup, ToolbarSection, ToolbarItem } from '@patternfly/react-core';
import { Toolbar } from '@patternfly/react-core/dist/js/layouts/Toolbar/Toolbar'
import { ToolbarGroup } from '@patternfly/react-core/dist/js/layouts/Toolbar/ToolbarGroup'
import { ToolbarSection } from '@patternfly/react-core/dist/js/layouts/Toolbar/ToolbarSection'
import { ToolbarItem } from '@patternfly/react-core/dist/js/layouts/Toolbar/ToolbarItem'

class SimpleToolbarSection extends React.Component {
render() {
Expand Down
7 changes: 6 additions & 1 deletion packages/patternfly-4/react-docs/src/pages/icons.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import React from 'react';
import { Title, Grid, GridItem, Tooltip, Text, PageSection } from '@patternfly/react-core';
import { Title } from '@patternfly/react-core/dist/js/components/Title/Title'
import { Tooltip } from '@patternfly/react-core/dist/js/components/Tooltip/Tooltip'
import { Text } from '@patternfly/react-core/dist/js/components/Text/Text'
import { Grid } from '@patternfly/react-core/dist/js/layouts/Grid/Grid'
import { GridItem } from '@patternfly/react-core/dist/js/layouts/Grid/GridItem'
import { PageSection } from '@patternfly/react-core/dist/js/components/Page/PageSection';
import { global_spacer_md as spacerMd, global_FontSize_sm as labelFontSize } from '@patternfly/react-tokens';
import * as IconsModule from '@patternfly/react-icons';
import { SideNavLayout } from 'gatsby-theme-patternfly-org/layouts';
Expand Down
3 changes: 2 additions & 1 deletion packages/patternfly-4/react-docs/src/pages/index.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import React from 'react';
import PropTypes from 'prop-types';
import { graphql } from 'gatsby';
import { Title, PageSection, PageSectionVariants } from '@patternfly/react-core';
import { Title } from '@patternfly/react-core/dist/js/components/Title/Title'
import { PageSection, PageSectionVariants } from '@patternfly/react-core/dist/js/components/Page/PageSection'
import { SideNavLayout } from 'gatsby-theme-patternfly-org/layouts';

const containerStyle = {
Expand Down
2 changes: 1 addition & 1 deletion ...ages/patternfly-4/react-inline-edit-extension/src/components/CancelButton/CancelButton.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import { CloseIcon } from '@patternfly/react-icons';
import { Button } from '@patternfly/react-core';
import { Button } from '@patternfly/react-core/dist/js/components/Button/Button';

const CancelButton = props => (
<Button {...props}>
Expand Down
2 changes: 1 addition & 1 deletion ...es/patternfly-4/react-inline-edit-extension/src/components/ConfirmButton/ConfirmButton.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import { CheckIcon } from '@patternfly/react-icons';
import { Button } from '@patternfly/react-core';
import { Button } from '@patternfly/react-core/dist/js/components/Button/Button';

const ConfirmButton = props => (
<Button {...props}>
Expand Down
2 changes: 1 addition & 1 deletion ...patternfly-4/react-inline-edit-extension/src/components/InlineEdit/InlineEdit.api.test.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { mount } from 'enzyme';
import { Table, TableHeader, TableBody, RowWrapper } from '@patternfly/react-table';
import { TextInput } from '@patternfly/react-core';
import { TextInput } from '@patternfly/react-core/dist/js/components/TextInput/TextInput';

import { default as editableRowWrapper } from './editableRowWrapper';
import { default as editableTableBody } from './editableTableBody';
Expand Down
2 changes: 1 addition & 1 deletion ...patternfly-4/react-inline-edit-extension/src/components/InlineEdit/editableTableBody.d.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, FunctionComponent, MouseEvent } from 'react';
import { TableBodyProps, IRowData, IExtraRowData } from '@patternfly/react-table';
import { OneOf } from '@patternfly/react-core';
import { Omit } from '@patternfly/react-core/dist/js/helpers/typeUtils';

import { TableEditConfirmation } from './constants';

Expand Down
3 changes: 2 additions & 1 deletion ...atternfly-4/react-inline-edit-extension/src/components/TableTextInput/TableTextInput.d.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { SFC, FormEvent } from 'react';
import { TextInputProps, Omit } from '@patternfly/react-core';
import { TextInputProps } from '@patternfly/react-core/dist/js/components/TextInput';
import { Omit } from '@patternfly/react-core/dist/js/helpers/typeUtils';

export interface TableTextInputProps extends Omit<TextInputProps, 'defaultValue' | 'autoFocus' | 'onBlur'> {
defaultValue?: string;
Expand Down
2 changes: 1 addition & 1 deletion .../patternfly-4/react-inline-edit-extension/src/components/TableTextInput/TableTextInput.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { TextInput } from '@patternfly/react-core';
import { TextInput } from '@patternfly/react-core/dist/js/components/TextInput/TextInput';
import PropTypes from 'prop-types';

const textInputProptypes = { ...TextInput.propTypes };
Expand Down
2 changes: 1 addition & 1 deletion packages/patternfly-4/react-integration/demo-app-ts/src/common/State.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { SelectOptionObject } from '@patternfly/react-core';
import { SelectOptionObject } from '@patternfly/react-core/dist/js/components/Select/SelectOption';

export class State implements SelectOptionObject {
name: string;
Expand Down
13 changes: 5 additions & 8 deletions packages/patternfly-4/react-table/src/components/Table/ActionsColumn.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import * as React from 'react';
import {
Dropdown,
DropdownPosition,
DropdownDirection,
KebabToggle,
DropdownItem,
DropdownSeparator
} from '@patternfly/react-core';
import { Dropdown } from '@patternfly/react-core/dist/js/components/Dropdown/Dropdown';
import { DropdownPosition, DropdownDirection } from '@patternfly/react-core/dist/js/components/Dropdown/dropdownConstants';
import { KebabToggle } from '@patternfly/react-core/dist/js/components/Dropdown/KebabToggle';
import { DropdownItem } from '@patternfly/react-core/dist/js/components/Dropdown/DropdownItem';
import { DropdownSeparator } from '@patternfly/react-core/dist/js/components/Dropdown/Separator';

import { IAction, IExtraData, IRowData } from './Table';

Expand Down
2 changes: 1 addition & 1 deletion packages/patternfly-4/react-table/src/components/Table/CollapseColumn.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as React from 'react';
import { AngleDownIcon } from '@patternfly/react-icons';
import { css } from '@patternfly/react-styles';
import { Button } from '@patternfly/react-core';
import { Button } from '@patternfly/react-core/dist/js/components/Button/Button';
import styles from '@patternfly/react-styles/css/components/Table/table';

export interface CollapseColumnProps {
Expand Down
3 changes: 2 additions & 1 deletion packages/patternfly-4/react-table/src/components/Table/RowWrapper.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as React from 'react';
import { InjectedOuiaProps, withOuiaContext, debounce } from '@patternfly/react-core';
import { InjectedOuiaProps, withOuiaContext } from '@patternfly/react-core/dist/js/components/withOuia/withOuia';
import { debounce } from '@patternfly/react-core/dist/js/helpers/util';
import styles from '@patternfly/react-styles/css/components/Table/table';
import { css } from '@patternfly/react-styles';

Expand Down
5 changes: 4 additions & 1 deletion packages/patternfly-4/react-table/src/components/Table/Table.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import * as React from 'react';
import styles from '@patternfly/react-styles/css/components/Table/table';
import stylesGrid from '@patternfly/react-styles/css/components/Table/table-grid';
import { InjectedOuiaProps, withOuiaContext, DropdownPosition, DropdownDirection, DropdownItemProps, Omit } from '@patternfly/react-core';
import { InjectedOuiaProps, withOuiaContext } from '@patternfly/react-core/dist/js/components/withOuia/withOuia';
import { DropdownDirection, DropdownPosition } from '@patternfly/react-core/dist/js/components/Dropdown/dropdownConstants'
import { DropdownItemProps } from '@patternfly/react-core/dist/js/components/Dropdown/DropdownItem'
import { Omit } from '@patternfly/react-core/dist/js/helpers/typeUtils'
import { css, getModifier } from '@patternfly/react-styles';
import { Provider } from './base';
import { BodyCell } from './BodyCell';
Expand Down
2 changes: 1 addition & 1 deletion packages/patternfly-4/react-table/src/components/Table/utils/decorators/compoundExpand.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import { css } from '@patternfly/react-styles';
import { Button } from '@patternfly/react-core';
import { Button } from '@patternfly/react-core/dist/js/components/Button/Button';
import styles from '@patternfly/react-styles/css/components/Table/table';
import { IExtra, IFormatterValueType, ITransform } from '../../Table';

Expand Down
3 changes: 2 additions & 1 deletion packages/patternfly-4/react-topology/src/components/TopologyView/TopologyView.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as React from 'react';
import { Stack, StackItem } from '@patternfly/react-core';
import { Stack } from '@patternfly/react-core/dist/js/layouts/Stack/Stack';
import { StackItem } from '@patternfly/react-core/dist/js/layouts/Stack/StackItem';
import '@patternfly/react-styles/css/components/Topology/topology-view.css';

export interface TopologyViewProps extends React.HTMLProps<HTMLDivElement> {
Expand Down
3 changes: 2 additions & 1 deletion packages/patternfly-4/react-topology/src/components/TopologyView/examples/ItemDetails.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import { Title, TitleLevel, BaseSizes } from '@patternfly/react-core';
import { Title, TitleLevel } from '@patternfly/react-core/dist/js/components/Title/Title';
import { BaseSizes } from '@patternfly/react-core';
import { TopologySideBar } from '@patternfly/react-topology';

export class ItemDetails extends React.Component {
Expand Down
20 changes: 9 additions & 11 deletions packages/patternfly-4/react-topology/src/components/TopologyView/examples/ProjectToolbar.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
import React from 'react';
import {
Dropdown,
DropdownPosition,
DropdownToggle,
DropdownItem,
Stack,
StackItem,
Toolbar,
ToolbarGroup,
ToolbarItem
} from '@patternfly/react-core';
import { Dropdown } from '@patternfly/react-core/dist/js/components/Dropdown/Dropdown'
import { DropdownItem } from '@patternfly/react-core/dist/js/components/Dropdown/DropdownItem'
import { DropdownToggle } from '@patternfly/react-core/dist/js/components/Dropdown/DropdownToggle'
import { DropdownPosition } from '@patternfly/react-core/dist/js/components/Dropdown/dropdownConstants'
import { Stack } from '@patternfly/react-core/dist/js/layouts/Stack/Stack'
import { StackItem } from '@patternfly/react-core/dist/js/layouts/Stack/StackItem'
import { Toolbar } from '@patternfly/react-core/dist/js/layouts/Toolbar/Toolbar'
import { ToolbarGroup } from '@patternfly/react-core/dist/js/layouts/Toolbar/ToolbarGroup'
import { ToolbarItem } from '@patternfly/react-core/dist/js/layouts/Toolbar/ToolbarItem'

const projects = [
{ id: 1, name: 'Project 1' },
Expand Down
Back | FazBrowse Home | New Git URL