FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(DataToolbar): Revert promotion of Datatoolbar from Experimental by tlabaj · Pull Request #3580 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(DataToolbar): Revert promotion of Datatoolbar from Experimental - #3580

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
tlabaj:revert_datatoolbar_promote
Jan 27, 2020
ConversationCommits (1)ChecksFiles changed
Merged

chore(DataToolbar): Revert promotion of Datatoolbar from Experimental#3580
dlabaj merged 1 commit into
patternfly:masterfrom
tlabaj:revert_datatoolbar_promote

Conversation

tlabaj commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

#3579

What: Closes #

Additional issues:

tlabaj requested review from dlabaj and dlabrecq January 24, 2020 18:17

patternfly-build commented Jan 24, 2020

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-3580.surge.sh

codecov-io commented Jan 24, 2020

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@82f1a46). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3580   +/-   ##
=========================================
  Coverage          ?   67.11%           
=========================================
  Files             ?      903           
  Lines             ?    25515           
  Branches          ?     2262           
=========================================
  Hits              ?    17125           
  Misses            ?     7349           
  Partials          ?     1041
Flag Coverage Δ
#misc 95.45% <ø> (?)
#patternfly3 69.29% <ø> (?)
#patternfly4 64.22% <100%> (?)
Impacted Files Coverage Δ
...ckages/patternfly-4/react-core/src/helpers/util.ts 50.53% <ø> (ø)
...mental/components/DataToolbar/DataToolbarUtils.tsx 100% <ø> (ø)
...xperimental/components/DataToolbar/DataToolbar.tsx 79.24% <ø> (ø)
...ental/components/DataToolbar/DataToolbarFilter.tsx 87.5% <100%> (ø)
.../components/DataToolbar/DataToolbarToggleGroup.tsx 70% <100%> (ø)
...mental/components/DataToolbar/DataToolbarGroup.tsx 100% <100%> (ø)
...nents/DataToolbar/DataToolbarExpandableContent.tsx 96.29% <100%> (ø)
...ntal/components/DataToolbar/DataToolbarContent.tsx 100% <100%> (ø)
...imental/components/DataToolbar/DataToolbarItem.tsx 91.3% <100%> (ø)
...onents/DataToolbar/DataToolbarChipGroupContent.tsx 81.81% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f1a46...c1de622. Read the comment docs.

dlabrecq approved these changes Jan 24, 2020
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit a679129 into patternfly:master Jan 27, 2020

patternfly-build commented Jan 27, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.2.1
  • @patternfly/react-core@3.133.1
  • @patternfly/react-docs@4.17.2
  • @patternfly/react-inline-edit-extension@2.15.2
  • demo-app-ts@3.18.1
  • @patternfly/react-integration@3.18.2
  • @patternfly/react-table@2.25.2
  • @patternfly/react-topology@2.12.1
  • @patternfly/react-virtualized-extension@1.3.89

Thanks for your contribution! 🎉

tlabaj mentioned this pull request Jan 27, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
dgutride dgutride approved these changes
dlabrecq dlabrecq approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL