FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(DataToolbar): Revert promotion of Datatoolbar from Experimental by tlabaj · Pull Request #3580 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(DataToolbar): Revert promotion of Datatoolbar from Experimental #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlabaj merged 1 commit into from
Jan 27, 2020
Conversation 4 Commits 1 Checks 0 Files changed
Merged

chore(DataToolbar): Revert promotion of Datatoolbar from Experimental #3580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .js  (1) .md  (2) .snap  (1) .ts  (4) .tsx  (11) All 5 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
        • index.ts
          • DataToolbar.test.tsx
          • DataToolbar.tsx
          • DataToolbarChipGroupContent.tsx
          • DataToolbarContent.tsx
          • DataToolbarExpandableContent.tsx
          • DataToolbarFilter.tsx
          • DataToolbarGroup.tsx
          • DataToolbarItem.tsx
          • DataToolbarToggleGroup.tsx
          • DataToolbarUtils.tsx
            • DataToolbar.test.tsx.snap
            • DataToolbar.md
          • index.ts
        • index.ts
        • util.ts
      • DataToolbarDemo.tsx
1 change: 0 additions & 1 deletion packages/patternfly-4/react-core/src/components/index.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export * from './ChipGroup';
export * from './ClipboardCopy';
export * from './ContextSelector';
export * from './DataList';
export * from './DataToolbar';
export * from './Divider';
export * from './Dropdown';
export * from './EmptyState';
Expand Down
4 changes: 2 additions & 2 deletions packages/patternfly-4/react-core/src/demos/FilterTableDemo.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ DataToolbarItem,
DataToolbarContent,
DataToolbarFilter,
DataToolbarToggleGroup,
DataToolbarGroup } from '@patternfly/react-core';
DataToolbarGroup } from '@patternfly/react-core/dist/esm/experimental';
import {
Title,
Select,
Expand All @@ -39,7 +39,7 @@ import {
DataToolbarFilter,
DataToolbarToggleGroup,
DataToolbarGroup
} from '@patternfly/react-core';
} from '@patternfly/react-core/dist/esm/experimental';
import {
Button,
ButtonVariant,
Expand Down
4 changes: 2 additions & 2 deletions ...mponents/DataToolbar/DataToolbar.test.tsx → ...mponents/DataToolbar/DataToolbar.test.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ import { DataToolbar } from './DataToolbar';
import { DataToolbarContent } from './DataToolbarContent';
import { DataToolbarGroup } from './DataToolbarGroup';
import { CloneIcon, EditIcon, FilterIcon } from '@patternfly/react-icons';
import { Button } from '../Button';
import { Button } from '../../../components/Button';
import { DataToolbarItem } from './DataToolbarItem';
import { DataToolbarChip, DataToolbarFilter } from './DataToolbarFilter';
import { DataToolbarToggleGroup } from './DataToolbarToggleGroup';
import { Select, SelectOption, SelectVariant } from '../Select';
import { Select, SelectOption, SelectVariant } from '../../../components/Select';

describe('data toolbar', () => {
test('DataToolbarOneContent', () => {
Expand Down
0 ...rc/components/DataToolbar/DataToolbar.tsx → ...al/components/DataToolbar/DataToolbar.tsx
Show comments
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...taToolbar/DataToolbarChipGroupContent.tsx → ...taToolbar/DataToolbarChipGroupContent.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ import { css, getModifier } from '@patternfly/react-styles';

import { RefObject } from 'react';
import { DataToolbarItem } from './DataToolbarItem';
import { Button } from '../Button';
import { Button } from '../../../components/Button';
import { DataToolbarGroup } from './DataToolbarGroup';
import { globalBreakpoints } from './DataToolbarUtils';
import { PickOptional } from '../../helpers/typeUtils';
import { PickOptional } from '../../../helpers/typeUtils';

export interface DataToolbarChipGroupContentProps extends React.HTMLProps<HTMLDivElement> {
/** Classes applied to root element of the data toolbar content row */
Expand Down
2 changes: 1 addition & 1 deletion ...onents/DataToolbar/DataToolbarContent.tsx → ...onents/DataToolbar/DataToolbarContent.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import styles from '@patternfly/react-styles/css/components/DataToolbar/data-too
import { css } from '@patternfly/react-styles';

import { DataToolbarBreakpointMod, DataToolbarContentContext } from './DataToolbarUtils';
import { formatBreakpointMods } from '../../helpers/util';
import { formatBreakpointMods } from '../../../helpers/util';
import { DataToolbarExpandableContent } from './DataToolbarExpandableContent';

export interface DataToolbarContentProps extends React.HTMLProps<HTMLDivElement> {
Expand Down
4 changes: 2 additions & 2 deletions ...aToolbar/DataToolbarExpandableContent.tsx → ...aToolbar/DataToolbarExpandableContent.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { css, getModifier } from '@patternfly/react-styles';
import { RefObject } from 'react';
import { DataToolbarGroup } from './DataToolbarGroup';
import { DataToolbarItem } from './DataToolbarItem';
import { Button } from '../Button';
import { Button } from '../../../components/Button';
import { DataToolbarContext } from './DataToolbarUtils';
import { PickOptional } from '../../helpers/typeUtils';
import { PickOptional } from '../../../helpers/typeUtils';

export interface DataToolbarExpandableContentProps extends React.HTMLProps<HTMLDivElement> {
/** Classes added to the root element of the data toolbar expandable content */
Expand Down
4 changes: 2 additions & 2 deletions ...ponents/DataToolbar/DataToolbarFilter.tsx → ...ponents/DataToolbar/DataToolbarFilter.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import * as React from 'react';
import * as ReactDOM from 'react-dom';
import { DataToolbarItem, DataToolbarItemProps } from './DataToolbarItem';
import { ChipGroup, Chip, ChipGroupToolbarItem } from '../ChipGroup';
import { ChipGroup, Chip, ChipGroupToolbarItem } from '../../../components/ChipGroup';
import { DataToolbarContentContext, DataToolbarContext } from './DataToolbarUtils';
import { PickOptional } from '../../helpers/typeUtils';
import { PickOptional } from '../../../helpers/typeUtils';

export interface DataToolbarChip {
/** A unique key to identify this chip */
Expand Down
4 changes: 2 additions & 2 deletions ...mponents/DataToolbar/DataToolbarGroup.tsx → ...mponents/DataToolbar/DataToolbarGroup.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import * as React from 'react';
import styles from '@patternfly/react-styles/css/components/DataToolbar/data-toolbar';
import { css, getModifier } from '@patternfly/react-styles';
import { Omit } from '../../helpers/typeUtils';
import { Omit } from '../../../helpers/typeUtils';
import { DataToolbarBreakpointMod } from './DataToolbarUtils';
import { formatBreakpointMods } from '../../helpers/util';
import { formatBreakpointMods } from '../../../helpers/util';
import { RefObject } from 'react';

export enum DataToolbarGroupVariant {
Expand Down
2 changes: 1 addition & 1 deletion ...omponents/DataToolbar/DataToolbarItem.tsx → ...omponents/DataToolbar/DataToolbarItem.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import styles from '@patternfly/react-styles/css/components/DataToolbar/data-too
import { css, getModifier } from '@patternfly/react-styles';

import { DataToolbarBreakpointMod } from './DataToolbarUtils';
import { formatBreakpointMods } from '../../helpers/util';
import { formatBreakpointMods } from '../../../helpers/util';

export enum DataToolbarItemVariant {
separator = 'separator',
Expand Down
6 changes: 3 additions & 3 deletions ...ts/DataToolbar/DataToolbarToggleGroup.tsx → ...ts/DataToolbar/DataToolbarToggleGroup.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ import styles from '@patternfly/react-styles/css/components/DataToolbar/data-too
import { css, getModifier } from '@patternfly/react-styles';
import { DataToolbarGroupProps } from './DataToolbarGroup';
import { DataToolbarContext, DataToolbarContentContext } from './DataToolbarUtils';
import { Button } from '../Button';
import { Button } from '../../../components/Button';
import { global_breakpoint_lg as globalBreakpointLg } from '@patternfly/react-tokens';

import { DataToolbarBreakpointMod } from './DataToolbarUtils';
import { formatBreakpointMods } from '../../helpers/util';
import { PickOptional } from '../../helpers/typeUtils';
import { formatBreakpointMods } from '../../../helpers/util';
import { PickOptional } from '../../../helpers/typeUtils';

export interface DataToolbarToggleGroupProps extends DataToolbarGroupProps {
/** An icon to be rendered when the toggle group has collapsed down */
Expand Down
0 ...mponents/DataToolbar/DataToolbarUtils.tsx → ...mponents/DataToolbar/DataToolbarUtils.tsx
Show comments
View file
Open in desktop
File renamed without changes.
0 ...r/__snapshots__/DataToolbar.test.tsx.snap → ...r/__snapshots__/DataToolbar.test.tsx.snap
Show comments
View file
Open in desktop
File renamed without changes.
19 changes: 10 additions & 9 deletions ...nents/DataToolbar/examples/DataToolbar.md → ...nents/DataToolbar/examples/DataToolbar.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
---
title: 'Data toolbar'
section: components
cssPrefix: 'pf-c-data-toolbar'
typescript: true
propComponents: ['DataToolbar', 'DataToolbarContent', 'DataToolbarItem', 'DataToolbarGroup', 'DataToolbarToggleGroup', 'DataToolbarFilter']
section: 'experimental'
experimentalStage: 'early'
---

import { DataToolbar , DataToolbarItem, DataToolbarGroup, DataToolbarContent, DataToolbarToggleGroup, DataToolbarFilter } from '@patternfly/react-core';
import { DataToolbar , DataToolbarItem, DataToolbarGroup, DataToolbarContent, DataToolbarToggleGroup, DataToolbarFilter } from '@patternfly/react-core/dist/esm/experimental';
import { Alert, Button, ButtonVariant, InputGroup, TextInput, Select, SelectOption } from '@patternfly/react-core';
import { EditIcon, CloneIcon, SyncIcon, SearchIcon, FilterIcon } from '@patternfly/react-icons'
import '@patternfly/react-styles/css/components/Divider/divider';
Expand All @@ -16,7 +17,7 @@ Toolbar items are individual components that can be placed inside of a toolbar.

```js title=Items
import React from 'react';
import { DataToolbar , DataToolbarItem, DataToolbarContent } from '@patternfly/react-core';
import { DataToolbar , DataToolbarItem, DataToolbarContent } from '@patternfly/react-core/dist/esm/experimental';
import { Button, ButtonVariant, InputGroup, TextInput } from '@patternfly/react-core';
import { SearchIcon } from '@patternfly/react-icons'

Expand Down Expand Up @@ -47,7 +48,7 @@ class DataToolbarItems extends React.Component {
```
```js title=Adjusting-item-spacers
import React from 'react';
import { DataToolbar , DataToolbarItem, DataToolbarGroup, DataToolbarContent } from '@patternfly/react-core';
import { DataToolbar , DataToolbarItem, DataToolbarGroup, DataToolbarContent } from '@patternfly/react-core/dist/esm/experimental';
import { Button } from '@patternfly/react-core';

class DataToolbarSpacers extends React.Component {
Expand Down Expand Up @@ -101,7 +102,7 @@ class DataToolbarSpacers extends React.Component {
Often, it makes sense to group sets of like items to create desired associations and to enable items to respond together to changes in viewport width. (Note: This example does not demonstrate the desired responsive behavior of the toolbar. That is handled in later examples.)
```js title=Groups
import React from 'react';
import { DataToolbar, DataToolbarContent, DataToolbarGroup, DataToolbarItem } from '@patternfly/react-core';
import { DataToolbar, DataToolbarContent, DataToolbarGroup, DataToolbarItem } from '@patternfly/react-core/dist/esm/experimental';
import { Button, Select, SelectOption } from '@patternfly/react-core';
import { EditIcon, CloneIcon, SyncIcon } from '@patternfly/react-icons'

Expand Down Expand Up @@ -271,7 +272,7 @@ The Toggle group can either have the toggle state managed by the consumer, or th
- The first Toggle group example below demonstrates a component managed toggle state.
```js title=Component-managed-toggle-groups
import React from 'react';
import { DataToolbar , DataToolbarItem, DataToolbarContent, DataToolbarToggleGroup, DataToolbarGroup } from '@patternfly/react-core';
import { DataToolbar , DataToolbarItem, DataToolbarContent, DataToolbarToggleGroup, DataToolbarGroup } from '@patternfly/react-core/dist/esm/experimental';
import { Button, ButtonVariant, InputGroup, Select, SelectOption, TextInput } from '@patternfly/react-core';
import { SearchIcon, FilterIcon } from '@patternfly/react-icons'

Expand Down Expand Up @@ -418,7 +419,7 @@ The second Toggle group example below demonstrates a consumer managed toggle sta

```js title=Consumer-managed-toggle-groups
import React from 'react';
import { DataToolbar , DataToolbarItem, DataToolbarContent, DataToolbarToggleGroup, DataToolbarGroup } from '@patternfly/react-core';
import { DataToolbar , DataToolbarItem, DataToolbarContent, DataToolbarToggleGroup, DataToolbarGroup } from '@patternfly/react-core//dist/esm/experimental';
import { Button, ButtonVariant, InputGroup, Select, SelectOption } from '@patternfly/react-core';
import { TextInput, SearchIcon, FilterIcon } from '@patternfly/react-icons'

Expand Down Expand Up @@ -580,7 +581,7 @@ import {
DataToolbarContent,
DataToolbarFilter,
DataToolbarToggleGroup,
DataToolbarGroup } from '@patternfly/react-core';
DataToolbarGroup } from '@patternfly/react-core//dist/esm/experimental';
import {
Button,
ButtonVariant,
Expand Down Expand Up @@ -808,7 +809,7 @@ class DataToolbarWithFilterExample extends React.Component {
There may be situations where all of the required elements simply cannot fit in a single line.
```js title=Stacked-example
import React from 'react';
import { DataToolbar, DataToolbarContent, DataToolbarToggleGroup, DataToolbarGroup, DataToolbarItem } from '@patternfly/react-core';
import { DataToolbar, DataToolbarContent, DataToolbarToggleGroup, DataToolbarGroup, DataToolbarItem } from '@patternfly/react-core/dist/esm/experimental';
import { Button, Select, SelectOption, Pagination, Dropdown, DropdownToggle, DropdownToggleCheckbox, DropdownItem } from '@patternfly/react-core';
import { FilterIcon, CloneIcon, SyncIcon } from '@patternfly/react-icons'

Expand Down
0 ...-core/src/components/DataToolbar/index.ts → ...erimental/components/DataToolbar/index.ts
Show comments
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/patternfly-4/react-core/src/experimental/components/index.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export * from '../../components/DataToolbar';
export * from './DataToolbar';
export * from '../../components/Divider';
export * from './Drawer';
export * from '../../components/OverflowMenu';
Expand Down
2 changes: 1 addition & 1 deletion packages/patternfly-4/react-core/src/helpers/util.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as ReactDOM from 'react-dom';
import { SIDE } from './constants';
import { getModifier } from '@patternfly/react-styles';
import { DataToolbarBreakpointMod } from '../components/DataToolbar/DataToolbarUtils';
import { DataToolbarBreakpointMod } from '../experimental/components/DataToolbar/DataToolbarUtils';
import { FlexBreakpointMod, FlexItemBreakpointMod } from '../layouts/Flex/FlexUtils';

export function capitalize(input: string) {
Expand Down
1 change: 1 addition & 0 deletions packages/patternfly-4/react-docs/gatsby-browser.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import '@patternfly/patternfly/patternfly.css';
// Utilities
import '@patternfly/patternfly/patternfly-addons.css';
// Experimental components
import '@patternfly/patternfly/components/DataToolbar/data-toolbar.css';
import '@patternfly/patternfly/components/Drawer/drawer.css';
// React-specific CSS
import '@patternfly/react-styles/src/css/components/Table/inline-edit.css';
Expand Down
4 changes: 3 additions & 1 deletion ...-4/react-integration/demo-app-ts/src/components/demos/DataToolbarDemo/DataToolbarDemo.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import {
DataToolbarFilter,
DataToolbarToggleGroup,
DataToolbarGroup,
DataToolbarProps,
DataToolbarProps
} from '@patternfly/react-core/dist/esm/experimental';
import {
Button,
ButtonVariant,
InputGroup,
Expand Down
Back | FazBrowse Home | New Git URL