FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Table: support for truncated column headers by jessiehuff · Pull Request #3729 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Table: support for truncated column headers - #3729

Merged
tlabaj merged 4 commits into
patternfly:masterfrom
jessiehuff:truncate-table
Feb 12, 2020
ConversationCommits (4)ChecksFiles changed
Merged

Table: support for truncated column headers#3729
tlabaj merged 4 commits into
patternfly:masterfrom
jessiehuff:truncate-table

Conversation

jessiehuff commented Feb 11, 2020

Copy link
Copy Markdown
Contributor

What: Closes #3608

patternfly-build commented Feb 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PF3 preview: https://patternfly-react-pr-3729-pf3.surge.sh
PF4 preview: https://patternfly-react-pr-3729.surge.sh
A11y report: https://patternfly-react-pr-3729-coverage.surge.sh

codecov-io commented Feb 11, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3729 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3729   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files         779      779           
  Lines       10489    10489           
  Branches     2261     2261           
=======================================
  Hits         7470     7470           
  Misses       2592     2592           
  Partials      427      427
Flag Coverage Δ
#misc 95.45% <ø> (ø) ⬆️
#patternfly3 85.89% <ø> (ø) ⬆️
#patternfly4 60.11% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...src/components/Table/utils/decorators/wrappable.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd2826...8bd8887. Read the comment docs.

tlabaj previously approved these changes Feb 12, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

seanforyou23 reviewed Feb 12, 2020
View reviewed changes

seanforyou23 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Left some comments. Should we also add a demo in react-integration to ensure these transforms continue to play nice together?

Comment thread packages/patternfly-4/react-core/src/demos/FilterTableDemo.md Outdated
Comment thread packages/patternfly-4/react-table/src/components/Table/Table.md Outdated
Comment thread packages/patternfly-4/react-table/src/components/Table/Table.md Outdated
dlabrecq previously approved these changes Feb 12, 2020
View reviewed changes
Comment thread packages/patternfly-4/react-table/src/components/Table/Table.md Outdated
jessiehuff dismissed stale reviews from dlabrecq and tlabaj via bfdf8d4 February 12, 2020 16:30
redallen approved these changes Feb 12, 2020
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! 🎖️

tlabaj approved these changes Feb 12, 2020
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

christiemolloy approved these changes Feb 12, 2020
View reviewed changes

christiemolloy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

tlabaj merged commit eab8040 into patternfly:master Feb 12, 2020

patternfly-build commented Feb 12, 2020

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@1.3.16
  • @patternfly/react-core@3.136.12
  • @patternfly/react-docs@4.18.19
  • @patternfly/react-inline-edit-extension@2.16.14
  • demo-app-ts@3.22.12
  • @patternfly/react-table@2.26.14
  • @patternfly/react-topology@2.13.15
  • @patternfly/react-virtualized-extension@1.3.110

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers
seanforyou23 seanforyou23 approved these changes
dlabrecq dlabrecq approved these changes
christiemolloy christiemolloy approved these changes
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Table: support for truncated column headers

8 participants

Back | FazBrowse Home | New Git URL