FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Table: support for truncated column headers by jessiehuff · Pull Request #3729 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

Table: support for truncated column headers #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 4 commits into from
Feb 12, 2020
Conversation 15 Commits 4 Checks 0 Files changed
Merged

Table: support for truncated column headers #3729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d286f42
Add sortable wrappable headers
jessiehuff Feb 11, 2020
73cfbdc
Adjust aria label
jessiehuff Feb 11, 2020
bfdf8d4
Address feedback
jessiehuff Feb 12, 2020
8bd8887
Clean up imports
jessiehuff Feb 12, 2020
File filter

Filter by extension

Filter by extension .md  (2) .ts  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
      • Table.md
        • wrappable.ts
23 changes: 10 additions & 13 deletions packages/patternfly-4/react-core/src/demos/FilterTableDemo.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -8,40 +8,37 @@ section: 'demos'
Uses the DataToolbar component to filter results in the table based on user input.

import {
Bullseye,
DataToolbar,
DataToolbarItem,
DataToolbarContent,
DataToolbarFilter,
DataToolbarGroup,
DataToolbarToggleGroup,
DataToolbarGroup } from '@patternfly/react-core/dist/esm/beta';
import {
Title,
Select,
SelectOption,
SelectVariant,
EmptyState,
EmptyStateIcon,
EmptyStateBody,
EmptyStateSecondaryActions,
Bullseye
Select,
SelectOption,
SelectVariant,
Title
} from '@patternfly/react-core';
import { SearchIcon } from '@patternfly/react-icons';
import { Table, TableHeader, TableBody} from '@patternfly/react-table';

```js title=Basic
import React from 'react';
import {
Button,
ButtonVariant,
Bullseye,
DataToolbar,
DataToolbarItem,
DataToolbarContent,
DataToolbarFilter,
DataToolbarToggleGroup,
DataToolbarGroup
} from '@patternfly/react-core/dist/esm/beta';
import {
Button,
ButtonVariant,
Bullseye,
DataToolbarGroup,
Dropdown,
DropdownItem,
DropdownPosition,
Expand Down
67 changes: 67 additions & 0 deletions packages/patternfly-4/react-table/src/components/Table/Table.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,73 @@ class SortableTable extends React.Component {
}
```

```js title=Sortable-with-wrapping-headers
import React from 'react';
import {
Table,
TableHeader,
TableBody,
sortable,
SortByDirection,
wrappable,
} from '@patternfly/react-table';

class SortableWrappingHeaders extends React.Component {
constructor(props) {
super(props);
this.state = {
columns: [
{
title: 'This is a really long table header that goes on for a long time 1.',
transforms: [sortable, wrappable]
},
{
title: 'This is a really long table header that goes on for a long time 2.',
transforms: [sortable, wrappable]
},
{
title: 'This is a really long table header that goes on for a long time 3.',
transforms: [sortable,wrappable]
},
{
title: 'This is a really long table header that goes on for a long time 4.',
transforms: [sortable, wrappable]
},
{
title: 'This is a really long table header that goes on for a long time 5.',
transforms: [sortable, wrappable]
},
],
rows: [['one', 'two', 'a', 'four', 'five'], ['a', 'two', 'k', 'four', 'five'], ['p', 'two', 'b', 'four', 'five']],
sortBy: {}
};
this.onSort = this.onSort.bind(this);
}

onSort(_event, index, direction) {
const sortedRows = this.state.rows.sort((a, b) => (a[index] < b[index] ? -1 : a[index] > b[index] ? 1 : 0));
this.setState({
sortBy: {
index,
direction
},
rows: direction === SortByDirection.asc ? sortedRows : sortedRows.reverse()
});
}

render() {
const { columns, rows, sortBy } = this.state;

return (
<Table aria-label="Sortable with Wrapping Headers" sortBy={sortBy} onSort={this.onSort} cells={columns} rows={rows}>
<TableHeader />
<TableBody />
</Table>
);
}
}
```

```js title=Selectable
import React from 'react';
import {
Expand Down
3 changes: 1 addition & 2 deletions packages/patternfly-4/react-table/src/components/Table/utils/decorators/wrappable.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { css, getModifier } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/Table/table';
import { ITransform } from '../../Table';

export const wrappable: ITransform = () => ({
className: css(getModifier(styles, 'wrap'))
className: styles.modifiers.wrap
});
Back | FazBrowse Home | New Git URL