Add sort support from @thomasmulvaney - #361
Open
halgari wants to merge 1 commit into
Open
halgari wants to merge 1 commit into
halgari wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I agree its not ideal. We could probably copy rpythons listsort code and make it so a comparison function can be passed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@halgari I've just implemented a better version using pixies mutable arrays and get performance on par with Clojure when run in JIT mode. It just needs some tidying up. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-adds @thomasmulvaney's merge-sort. It's not a bad algorithm, although the JIT will probably throw a fit with it. We should improve it in the future to a) use mutable arrays during sorting and b) investigate how to get the JIT to be happier. Perhaps we should re-write it in RPython to get C-like speeds and call into Pixie for the comparisons. At any rate, we need some sort of sort at this point. So let's work with this.