FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix sorting branch by thomasmulvaney · Pull Request #434 · pixie-lang/pixie · GitHub

Fix sorting branch - #434

Open
thomasmulvaney wants to merge 2 commits into
pixie-lang:masterfrom
thomasmulvaney:fix-sorting-branch
Open

thomasmulvaney wants to merge 2 commits into
pixie-lang:masterfrom
thomasmulvaney:fix-sorting-branch

Conversation

Copy link
Copy Markdown
Member

FIxes stackoverflow in JIT mode with a trampoline. We should still look for a C lib that could do this stuff or at least do a dirty mutating approach which is more JIT friendly. For now this is at least a simple solution.

heyLu commented Nov 7, 2015

Copy link
Copy Markdown
Member

Can you make the helper functions (trampoline and the -merge fns) private?

You also mentioned in #361 that you had implemented a version using arrays, do you still have that or did it not work out?

Copy link
Copy Markdown
Member Author

I agree the helpers should be private. Trampoline might be the exception as
it is rather useful. My mutating version got over ambitious when I tried
adding some of the TimSort optimizations - it's rather broken at the moment.

I'll make those adjusts tomorrow evening.

Cheers
On Nov 7, 2015 9:42 AM, "Lucas Stadler" notifications@github.com wrote:

Can you make the helper functions (trampoline and the -merge fns) private?

You also mentioned in #361 that you had implemented a version using
arrays, do you still have that or did it not work out?

—
Reply to this email directly or view it on GitHub.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL