ensures that padded space is not larger than figure - #3
Conversation
Sorry, something went wrong.
|
I added the built files to commit 6f19390 to enable easy inclusion in plotly.js' package.json file. The reason I had to do this is probably because plotly.js is ES5 whereas this module uses ES6! |
Sorry, something went wrong.
| var L = max(nodesByBreadth, function(nodes) { | ||
| return nodes.length; | ||
| }); | ||
| var maxNodePadding = 2/3 * size[1] / (L - 1); |
There was a problem hiding this comment.
I like the 2/3 - looks good. Lets define it up top though by the properties block:
Lines 7 to 11 in 6f19390
not that I think we need to make it a property now, though we may want to do that later. For now I just want it to be easier to find, in case someone's wondering why they get our warning (or why the padding refuses to get bigger)
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you for pointing this out! It should now be resolved in commit 1a79abb!
Sorry, something went wrong.
|
💃 Very nice and clean! |
Sorry, something went wrong.
In order to fix this issue plotly/plotly.js#3140, we override nodePadding if it's too large.